Skip to content

[AutoComplete] Only render placeholder attribute when the parameter is provided #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvoituron merged 6 commits into from
Jun 14, 2025
Merged

[AutoComplete] Only render placeholder attribute when the parameter is provided #3919

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc34167
Add null check to show placeholder
MarvinKlein1508 Jun 14, 2025
45fbcb9
Remove checks all together
MarvinKlein1508 Jun 14, 2025
9dac9f7
Update Unit-tests
MarvinKlein1508 Jun 14, 2025
b3ea04f
Do not display placeholder when an item is selected
MarvinKlein1508 Jun 14, 2025
e814214
Update unit tests
MarvinKlein1508 Jun 14, 2025
d7a66eb
Only set placeholder attribute when the user provides ones
MarvinKlein1508 Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove checks all together
  • Loading branch information
@MarvinKlein1508
MarvinKlein1508 committed Jun 14, 2025
commit 45fbcb911d8707c3b2cedfef991823f8cc2eaba7
2 changes: 1 addition & 1 deletion src/Core/Components/List/FluentAutocomplete.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
ReadOnly="@ReadOnly"
Label="@Label"
LabelTemplate="@LabelTemplate"
Placeholder="@(SelectedOptions is null || SelectedOptions?.Any() is false ? Placeholder : string.Empty)"
Placeholder="@Placeholder"
aria-expanded="@(IsMultiSelectOpened ? "true" : "false")"
aria-controls="@(IsMultiSelectOpened ? IdPopup : string.Empty)"
aria-label="@GetAutocompleteAriaLabel()"
Expand Down