-
Notifications
You must be signed in to change notification settings - Fork 461
[Drag&Drop] Add stopPropagation to DropZone #4045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why not add a parameter like we did in FluentButton? That way, the developer can decide when to use it. /// <summary>
/// Gets or sets a way to prevent further propagation of the current event in the capturing and bubbling phases.
/// </summary>
[Parameter]
public bool StopPropagation { get; set; } = false; |
Good call! I will adjust the PR early tomorrow. |
|
Done. I've also added a test for the new parameter. |
Pull Request
📖 Description
This PR adds stopPropagation to the
FluentDropZonecomponent. This allows the component to be used in nestedFluentDragContainercomponents.🎫 Issues
This PR fixes #3925
👩💻 Reviewer Notes
@dvoituron I'm not sure if I can always set
stopPropagation. I've seen that you do this for preventDeafult based onDroppable. But I couldn't find any downside in adding this attribute.📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps
I've got a working demo with three nested
FluentDragContainers which I prepare for PR as well. Still optimizing styling. Here is a sneak peak:https://github.com/user-attachments/assets/5c5eefe0-1eb7-4e37-93f0-7ce5f9775cb6