-
Notifications
You must be signed in to change notification settings - Fork 460
[ListBaseComponent] Fix for default selection options #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ListBaseComponent] Fix for default selection options #4135
Conversation
|
Give me a few days to verify these changes. One initial note: You cannot change the unit tests. If that is required, it is a breaking change. |
No rush at all 😊 I’m also happy to discuss this further over a Teams call if that would help. |
|
Just realized something, when working with a list of strings the reference will be different while the value might be the same. |
3482d5c to
46ec34c
Compare
|
Ok, that’s better. I was making it way harder than the issue actually was. 😐 |
Pull Request
📖 Description
Replace
item?.Tostring()to determine current selected value as this would result inNamespaceName.MyClassfor most cases.Now uses a hash key as the default and not the
GetHashCodefor security.🎫 Issues
Fix #4128
✅ Checklist
General
Component-specific