Skip to content

Conversation

@Tyme-Bleyaert
Copy link
Collaborator

Pull Request

📖 Description

Replace item?.Tostring() to determine current selected value as this would result in NamespaceName.MyClass for most cases.
Now uses a hash key as the default and not the GetHashCode for security.

🎫 Issues

Fix #4128

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

@Tyme-Bleyaert Tyme-Bleyaert marked this pull request as ready for review September 13, 2025 13:37
@dvoituron
Copy link
Collaborator

Give me a few days to verify these changes. One initial note: You cannot change the unit tests. If that is required, it is a breaking change.

@Tyme-Bleyaert
Copy link
Collaborator Author

Give me a few days to verify these changes. One initial note: You cannot change the unit tests. If that is required, it is a breaking change.

No rush at all 😊
You’re right that changing tests typically implies a breaking change, but in this case, most of the tests I updated were either checking ToString() outputs or performing *.verified.razor.html comparisons with hardcoded option values. So while it could be a breaking change, I’d expect it to only affect very specific edge cases.

I’m also happy to discuss this further over a Teams call if that would help.

@Tyme-Bleyaert Tyme-Bleyaert marked this pull request as draft September 15, 2025 11:48
@Tyme-Bleyaert
Copy link
Collaborator Author

Just realized something, when working with a list of strings the reference will be different while the value might be the same.
I need to address that issue first. So i marked the pr as draft again.

@Tyme-Bleyaert Tyme-Bleyaert force-pushed the fix/default-selection-lists branch from 3482d5c to 46ec34c Compare September 15, 2025 17:14
@Tyme-Bleyaert Tyme-Bleyaert marked this pull request as ready for review September 15, 2025 17:20
@Tyme-Bleyaert
Copy link
Collaborator Author

Ok, that’s better. I was making it way harder than the issue actually was. 😐
Why write many lines when deleting one does the trick.

@dvoituron dvoituron enabled auto-merge (squash) September 19, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: always first item selected in FluentAutocomplete, when using *Templates

3 participants