Skip to content

Make colors customizable #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
Mar 25, 2021
Merged

Make colors customizable #242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f3c30
Make colors customizable
jiasli Mar 22, 2021
36625a1
not catch KeyError
jiasli Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
not catch KeyError
  • Loading branch information
@jiasli
jiasli committed Mar 24, 2021
commit 36625a1abfaf3ffa8047ee9bc4112e219fe9372a
5 changes: 1 addition & 4 deletions knack/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,7 @@ def __init__(self, log_level_config, log_format, enable_color):
def format(self, record):
msg = logging.StreamHandler.format(self, record)
if self.enable_color:
try:
msg = self.wrap_with_color(record.levelname, msg)
except KeyError:
pass
msg = self.wrap_with_color(record.levelname, msg)
Copy link
Member Author

@jiasli jiasli Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't ignore KeyError. As KeyError indicates color_map is corrupted.

return msg


Expand Down