Always use UTF-8 for log file encoding #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Reported by Azure/azure-cli#17994
On Windows with English as the system language (without UTC-8 enabled), the system encoding by default is
cp1252(Western Europe), and Python will usecp1252as the file encoding by default.Writing Unicode characters like
汉字to log file results in error:The error can also be easily reproduced with
Change
This PR forces log files to use UTF-8 so that file logging works on non-UTF-8 systems as well.
Alternative solution
One may also follow #178 to change the default encoding of the system to UTF-8.