Skip to content

Conversation

@csujedihy
Copy link
Collaborator

@csujedihy csujedihy commented Jul 4, 2023

Description

Caveats:

  1. openssl doesn't build for arm64. It looks like the issue has been fixed in VC-WIN64-ARM build fails in VS 2019 (OpenSSL 3.0.8) openssl/openssl#20234.

Testing

CI

@csujedihy csujedihy added Area: Automation github_actions Pull requests that update Github_actions code labels Jul 4, 2023
@csujedihy csujedihy marked this pull request as ready for review July 6, 2023 02:32
@csujedihy csujedihy requested a review from a team as a code owner July 6, 2023 02:32
if: inputs.test == '-Test'
shell: pwsh
run: scripts/build.ps1 -Config ${{ inputs.config }} -Platform ${{ inputs.plat }} -Arch ${{ inputs.arch }} -Tls ${{ inputs.tls }} -DisablePerf ${{ inputs.static }} ${{ inputs.clang }} ${{ inputs.systemcrypto }} ${{ inputs.codecheck }} ${{ inputs.sanitize }}
run: scripts/build.ps1 -Config ${{ inputs.config }} -Platform ${{ inputs.plat }} -Arch ${{ inputs.arch }} -Tls ${{ inputs.tls }} -DisablePerf ${{ inputs.static }} ${{ inputs.clang }} ${{ inputs.systemcrypto }} ${{ inputs.codecheck }} ${{ inputs.sanitize }} -OneBranch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix up the -OneBranch arg name since it's no longer specific to OneBranch.

@nibanks nibanks merged commit 0854e65 into main Jul 6, 2023
@nibanks nibanks deleted the huanyi/migrate-tests-to-github branch July 6, 2023 11:36
csujedihy pushed a commit that referenced this pull request Jul 8, 2023
raymondliu2022 pushed a commit to raymondliu2022/msquic that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Automation github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants