Skip to content

Don't send client CONNECTION_CLOSE on 1-RTT before handshake completion. #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nibanks merged 3 commits into from
Feb 23, 2024
Merged

Don't send client CONNECTION_CLOSE on 1-RTT before handshake completion. #4145

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83733f0
Don't send client CONNECTION_CLOSE on 1-RTT before handshake completion.
rzikm Feb 16, 2024
3ef1931
Fix tests
rzikm Feb 20, 2024
de3f2ef
Remove unwanted changes
rzikm Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unwanted changes
  • Loading branch information
@rzikm
rzikm committed Feb 20, 2024
commit de3f2ef87363e2ff9b37585e6e5923c7b0e20256
9 changes: 0 additions & 9 deletions src/test/lib/HandshakeTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,14 +820,6 @@ QuicTestConnectAndIdle(
}
}

void hexdump(FILE* f, void *ptr, int buflen) {
unsigned char *buf = (unsigned char*)ptr;
int i;
for (i=0; i<buflen; i+=1) {
fprintf(f, "%02x", buf[i]);
}
}

void
QuicTestCustomServerCertificateValidation(
_In_ bool AcceptCert,
Expand Down Expand Up @@ -865,7 +857,6 @@ QuicTestCustomServerCertificateValidation(
}
Listener.Context = &ServerAcceptCtx;

QUIC_TLS_SECRETS TlsSecrets{};
{
TestConnection Client(Registration);
TEST_TRUE(Client.IsValid());
Expand Down