Skip to content

localSocketAddress implementation #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

localSocketAddress implementation #2152

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c21b2f8
localSocketAddress implementation
tkyc Jun 20, 2023
3d0fee2
Added logging
tkyc Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added logging
  • Loading branch information
@tkyc
tkyc committed Jun 20, 2023
commit 3d0fee2027ea4d0a6c332a3b6f3eaaf11abd4433
4 changes: 4 additions & 0 deletions src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2895,6 +2895,10 @@ private Socket getConnectedSocket(InetSocketAddress addr, int timeoutInMilliSeco

if (null != localSocketAddress && !localSocketAddress.isEmpty()) {
selectedSocket.bind(new InetSocketAddress(InetAddress.getByName(localSocketAddress), 0));
Copy link
Contributor

@machavan machavan Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we validate this user specified loicalSocketAddress as a valid IP somewhere before coming here ? If not would it be good to handle an exception thrown by InetSocketAddress/bind call and raise an error in that case ?


if (logger.isLoggable(Level.FINER)) {
logger.finer(this.toString() + " binding socket to: " + localSocketAddress);
}
}

if (!selectedSocket.isConnected()) {
Expand Down