Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Return the failure from NotifyAdo as result instead of an exception #3555

Merged
chkeita merged 7 commits into from
Oct 17, 2023
Merged

Return the failure from NotifyAdo as result instead of an exception #3555

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5dbde1
Return the failure from NotifyAdo as result instead of an exception
chkeita Oct 6, 2023
f59b594
remove comment
chkeita Oct 6, 2023
f663973
requeue when notification fails
chkeita Oct 6, 2023
ea00e98
fix logic
chkeita Oct 6, 2023
796c7c9
Merge branch 'main' into bug_fix
chkeita Oct 10, 2023
21da574
Merge branch 'main' into bug_fix
chkeita Oct 10, 2023
4a25e76
Merge branch 'main' into bug_fix
chkeita Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into bug_fix
  • Loading branch information
@chkeita
chkeita authored Oct 13, 2023
commit 4a25e76d24a2ad5b4cf6f78bb0b6725c68aa6797
3 changes: 2 additions & 1 deletion src/ApiService/ApiService/OneFuzzTypes/Enums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ public enum ErrorCode {
ADO_VALIDATION_INVALID_PATH = 495,
ADO_VALIDATION_INVALID_PROJECT = 496,
INVALID_RETENTION_PERIOD = 497,
TRANSIENT_NOTIFICATION_FAILURE = 498,
INVALID_CLI_VERSION = 498,
TRANSIENT_NOTIFICATION_FAILURE = 499,
// NB: if you update this enum, also update enums.py
}

Expand Down
3 changes: 2 additions & 1 deletion src/pytypes/onefuzztypes/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ class ErrorCode(Enum):
ADO_VALIDATION_INVALID_PATH = 495
ADO_VALIDATION_INVALID_PROJECT = 496
INVALID_RETENTION_PERIOD = 497
TRANSIENT_NOTIFICATION_FAILURE = 498
INVALID_CLI_VERSION = 498
TRANSIENT_NOTIFICATION_FAILURE = 499
# NB: if you update this enum, also update Enums.cs


Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.