[EP ABI] Support for TENSOR type attribute #25566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

chilo-ms merged 21 commits into main from chi/add_ort_node_tensor_attribute

Jul 30, 2025

Contributor

chilo-ms commented Jul 28, 2025 •

edited

Loading

Description

Add a new Node_GetTensorAttributeAsOrtValue API to support attribute that is a TENSOR type.
This API returns a newly created OrtValue that represents the TensorProto in the TENSOR attribute, caller now owns it and needs to be cleaned up by ValueRelease or use Ort::Value.

chilo-ms added 4 commits

July 27, 2025 21:03


          Initial commit with experimental code

6da8bf6


          Remove the code not needed

006e07d


          update OrtGraph to proto util to support getting TENSOR attribute

7a2722e


          small update

fe02556

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

You can commit the suggested changes from lintrunner.

include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Outdated Show resolved Hide resolved


          fix minor issues

209122c

jywu-msft added the release:1.23.0 label

jywu-msft requested a review from adrianlizarraga

July 28, 2025 20:25

chilo-ms commented

View reviewed changes

include/onnxruntime/core/session/onnxruntime_c_api.h Show resolved Hide resolved

chilo-ms commented

View reviewed changes

onnxruntime/core/graph/ep_api_types.cc Show resolved Hide resolved

chilo-ms added 5 commits

July 28, 2025 13:42


          fix unused parameter warning

af17a24


          minor change to change the place the function declaration

2ab28ba


          forogt to add 'return nullptr'

b513207


          remove wrong comment and code

05d47be


          update code and add unit test

287d5b5

chilo-ms marked this pull request as ready for review

July 29, 2025 07:15

edgchen1 reviewed

View reviewed changes

include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Outdated Show resolved Hide resolved

include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Outdated Show resolved Hide resolved

include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Outdated Show resolved Hide resolved

onnxruntime/core/graph/abi_graph_types.h Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

onnxruntime/core/graph/model_editor_api_types.h Outdated Show resolved Hide resolved

onnxruntime/core/session/onnxruntime_c_api.cc Outdated Show resolved Hide resolved

onnxruntime/core/session/onnxruntime_c_api.cc Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

adrianlizarraga reviewed

View reviewed changes

onnxruntime/core/graph/abi_graph_types.h Outdated Show resolved Hide resolved

onnxruntime/core/session/onnxruntime_c_api.cc Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

chilo-ms and others added 3 commits

July 29, 2025 14:46


          address reviewers' comments

d2c0695


          make it on demand for creating and caching the 'TENSOR' attribute as …

3a46c88

…an OrtValue


          Merge branch 'main' into chi/add_ort_node_tensor_attribute

b81edf3

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

You can commit the suggested changes from lintrunner.

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

chilo-ms added 4 commits

July 29, 2025 15:53


          address lintrunner issue

f78d672


          Use onnx::TensorProto instead of unique_ptr<onnx::TensorProto>

103168b


          remove redundnat code

ba84595


          fix compile error

a3b843c

edgchen1 reviewed

View reviewed changes

include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Outdated Show resolved Hide resolved

include/onnxruntime/core/session/onnxruntime_c_api.h Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.h Outdated Show resolved Hide resolved


          Make the api return OrtValue without caching it, caller now owns it

d635adb

Contributor Author

chilo-ms commented Jul 30, 2025

do we need to cache them at all? there's the issue of caching on demand requiring a non-const OrtNode*. could we just return a newly created OrtValue?

Made the API return a newly create OrtValue, and caller now owns it and have to manually clean up by ReleaseValue or use Ort::Value.

edgchen1 reviewed

View reviewed changes

onnxruntime/core/graph/ep_api_types.h Outdated Show resolved Hide resolved

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved

onnxruntime/test/ep_graph/test_ep_graph.cc Outdated Show resolved Hide resolved

edgchen1 reviewed

View reviewed changes

onnxruntime/core/graph/ep_api_types.cc Outdated Show resolved Hide resolved


          address reviewer comments

53b355e

adrianlizarraga reviewed

View reviewed changes

onnxruntime/core/session/onnxruntime_c_api.cc Outdated Show resolved Hide resolved


          Move tensor attribute check into EpNode::GetTensorAttributeAsOrtValue

0b6a941

adrianlizarraga previously approved these changes

View reviewed changes

edgchen1 reviewed

View reviewed changes

include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Show resolved Hide resolved

include/onnxruntime/core/session/onnxruntime_c_api.h Outdated Show resolved Hide resolved

onnxruntime/core/graph/abi_graph_types.h Outdated Show resolved Hide resolved


          address reviewer comments

d9e40c0

chilo-ms dismissed adrianlizarraga’s stale review via

d9e40c0

July 30, 2025 18:20

edgchen1 approved these changes

View reviewed changes

adrianlizarraga approved these changes

View reviewed changes

chilo-ms merged commit 4a8a289 into main

92 of 95 checks passed

chilo-ms deleted the chi/add_ort_node_tensor_attribute branch

July 30, 2025 21:34

chilo-ms mentioned this pull request

Cherry-pick "[EP ABI] Support for TENSOR type attribute" PR into ORT 1.23.0 release branch #25606

Merged

snnn mentioned this pull request

[MIGraphX EP] Syncing AMD changes upstream #25583

Merged

chilo-ms mentioned this pull request

[EP ABI] Add OpAttr_GetTensorAttributeAsOrtValue and replace the existing Node_GetTensorAttributeAsOrtValue #25886

Merged

jywu-msft removed the release:1.23.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet