Skip to content

Conversation

@ankitm3k
Copy link
Contributor

@ankitm3k ankitm3k commented Aug 12, 2025

Description

This PR fixes the load_config handling logic delegating the filtering to be maintained by OV toolkit going ahead (this enables cache_dir for CPU device via load_config) & redundant upsample Op fixes.

@ankitm3k
Copy link
Contributor Author

@jywu-msft, @HectorSVC Kindly review & merge this PR

@HectorSVC HectorSVC requested a review from Copilot August 12, 2025 16:08
@HectorSVC HectorSVC added the ep:OpenVINO issues related to OpenVINO execution provider label Aug 12, 2025
@HectorSVC
Copy link
Contributor

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the load_config handling logic in the OpenVINO provider by removing redundant property validation and delegates the filtering to OpenVINO toolkit directly. This enables cache_dir for CPU device via load_config and removes redundant upsample operation fixes.

  • Removed local property validation logic and delegated to OpenVINO Core for better compatibility
  • Simplified property setting by removing custom supported/mutable property checks
  • Removed dimension-based filtering for upsample operations to fix redundant constraints

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
onnxruntime/core/providers/openvino/backends/basic_backend.cc Simplified property configuration by removing local validation and delegating to OpenVINO Core
onnxruntime/core/providers/openvino/ov_versions/data_ops.cc Removed dimension-based input validation for upsample operations

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@HectorSVC HectorSVC merged commit dfab5bf into microsoft:main Aug 12, 2025
86 checks passed
adrianlizarraga pushed a commit that referenced this pull request Aug 14, 2025
### Description
This PR fixes the load_config handling logic delegating the filtering to be maintained by OV toolkit going ahead (this enables cache_dir for CPU device via load_config) & redundant upsample Op fixes.

---------

Co-authored-by: jatinwadhwa921 <[email protected]>
adrianlizarraga added a commit that referenced this pull request Aug 18, 2025
### Description
Cherry-picks #25725 into
the `rel-1.23.0` branch.



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: jatinwadhwa921 <[email protected]>
derdeljan-msft pushed a commit that referenced this pull request Aug 21, 2025
### Description
Cherry-picks #25725 into
the `rel-1.23.0` branch.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

Co-authored-by: Ankit Maheshkar <[email protected]>
Co-authored-by: jatinwadhwa921 <[email protected]>
(cherry picked from commit 1d1712f)
gedoensmax pushed a commit to gedoensmax/onnxruntime that referenced this pull request Sep 2, 2025
### Description
This PR fixes the load_config handling logic delegating the filtering to be maintained by OV toolkit going ahead (this enables cache_dir for CPU device via load_config) & redundant upsample Op fixes.

---------

Co-authored-by: jatinwadhwa921 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ep:OpenVINO issues related to OpenVINO execution provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants