-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[OVEP] OpenVINO features v1.23.0 patch #25725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jywu-msft, @HectorSVC Kindly review & merge this PR |
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the load_config handling logic in the OpenVINO provider by removing redundant property validation and delegates the filtering to OpenVINO toolkit directly. This enables cache_dir for CPU device via load_config and removes redundant upsample operation fixes.
- Removed local property validation logic and delegated to OpenVINO Core for better compatibility
- Simplified property setting by removing custom supported/mutable property checks
- Removed dimension-based filtering for upsample operations to fix redundant constraints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| onnxruntime/core/providers/openvino/backends/basic_backend.cc | Simplified property configuration by removing local validation and delegating to OpenVINO Core |
| onnxruntime/core/providers/openvino/ov_versions/data_ops.cc | Removed dimension-based input validation for upsample operations |
|
Azure Pipelines successfully started running 5 pipeline(s). |
### Description This PR fixes the load_config handling logic delegating the filtering to be maintained by OV toolkit going ahead (this enables cache_dir for CPU device via load_config) & redundant upsample Op fixes. --------- Co-authored-by: jatinwadhwa921 <[email protected]>
### Description Cherry-picks #25725 into the `rel-1.23.0` branch. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Co-authored-by: Ankit Maheshkar <[email protected]> Co-authored-by: jatinwadhwa921 <[email protected]>
### Description Cherry-picks #25725 into the `rel-1.23.0` branch. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Co-authored-by: Ankit Maheshkar <[email protected]> Co-authored-by: jatinwadhwa921 <[email protected]> (cherry picked from commit 1d1712f)
### Description This PR fixes the load_config handling logic delegating the filtering to be maintained by OV toolkit going ahead (this enables cache_dir for CPU device via load_config) & redundant upsample Op fixes. --------- Co-authored-by: jatinwadhwa921 <[email protected]>
Description
This PR fixes the load_config handling logic delegating the filtering to be maintained by OV toolkit going ahead (this enables cache_dir for CPU device via load_config) & redundant upsample Op fixes.