[TRT RTX EP] Remove unused legacy code from TRT EP that is no longer supported for TRT RTX #25916
Conversation
gedoensmax
force-pushed
the
maximilianm/remove_dead_code
branch
from
ae66f2a to
3da443d
Compare
|
please resolve conflicts? @gedoensmax , I assume this and the other RTX EP changes should be all taken in together? |
|
This would not be strictly needed within 1.23. |
gedoensmax
force-pushed
the
maximilianm/remove_dead_code
branch
from
3da443d to
4926ba0
Compare
would it make it difficult to cherry pick other PR's if they are based on your changes? are there any other upcoming PR's targeting 1.23? |
|
@jywu-msft So far none are planned. There could of course be other minor fixes that we notice like: #25937 |
Fixes warnings on Clang.
This fixes warnings on Clang.
Should be between 0 and 2, not either smaller than 0 or smaller than 2 0 <= embed_mode || embed_mode < 2
gedoensmax
force-pushed
the
maximilianm/remove_dead_code
branch
from
4926ba0 to
a45308f
Compare
|
I rebased this branch. Can I get a rerun of the tests to get this merged ? |
|
@chilo-ms can you run the CI on this and merge ? |
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Do we want this PR to be in ORT now? |
|
Yeah that works for me as well. |
4 participants
Description
This PR cleans up the codebase of the EP and fixes some compile issues.