Skip to content

flowey: make values secret, not variables #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged

flowey: make values secret, not variables #1338

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08eb2fc
flowey: make values secret, not variables
jstarks May 5, 2025
4ee0174
fix eof
jstarks May 11, 2025
e5ef4a5
clippy
jstarks May 12, 2025
c050329
clippy
jstarks May 12, 2025
1f058f1
while we're here
jstarks May 16, 2025
e555567
fix ado
jstarks May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy
  • Loading branch information
@jstarks
jstarks committed May 16, 2025
commit c050329ecc59ea73c9a9f623128f914a3e8a60b4
2 changes: 1 addition & 1 deletion flowey/flowey_cli/src/cli/var_db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ impl VarDb {
EnvBackend::Ado => {
println!("##vso[task.setvariable variable={env};issecret={is_secret}]");
std::io::stdout().write_all(&data).unwrap();
println!("");
println!();
}
EnvBackend::Github => {
let data_string = String::from_utf8(data)?;
Expand Down
2 changes: 1 addition & 1 deletion flowey/flowey_cli/src/pipeline_resolver/github_yaml/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ fn resolve_flow_as_github_yaml_steps(
if let Some(condvar) = &condvar {
// guaranteed to be a bare bool `true`/`false`, hence
// is_raw_string = false
let set_condvar = var_db.write_to_gh_env(&condvar, "FLOWEY_CONDITION");
let set_condvar = var_db.write_to_gh_env(condvar, "FLOWEY_CONDITION");
bash_commands.push_minor(format!("{set_condvar}\n"));
}

Expand Down