Skip to content

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented Aug 20, 2020

Here are the changes required to decode the traces produced by generational aware analysis I introduced in dotnet/runtime#40332

Notice the latest change requires dotnet/runtime#41052

@cshung cshung force-pushed the public/dev/andrewau/decode-genaware-events branch 3 times, most recently from af96e30 to 7acb307 Compare August 20, 2020 21:17
@cshung cshung changed the title Decoding traces produced by generational aware analysis. [WIP] Decoding traces produced by generational aware analysis. Aug 21, 2020
@brianrob
Copy link
Member

@cshung, I realize this is WIP, but wanted to give a quick bit of feedback. Overall, looks good, but I did notice that there is some addition of code to handle Gen4. I don't believe any work has been done in PerfView thus far to handle the pinned object heap, so I wanted to make sure that this is coordinated with any other work that might be done by your team on the pinned object heap.

@cshung cshung force-pushed the public/dev/andrewau/decode-genaware-events branch from 7acb307 to 99f3669 Compare August 22, 2020 00:19
@cshung cshung changed the title [WIP] Decoding traces produced by generational aware analysis. Decoding traces produced by generational aware analysis. Aug 22, 2020
@cshung
Copy link
Contributor Author

cshung commented Aug 22, 2020

@cshung, I realize this is WIP, but wanted to give a quick bit of feedback. Overall, looks good, but I did notice that there is some addition of code to handle Gen4. I don't believe any work has been done in PerfView thus far to handle the pinned object heap, so I wanted to make sure that this is coordinated with any other work that might be done by your team on the pinned object heap.

I am adding gen 4 support just to avoid asserting when trying to decode the generation bounds event. I didn't test it for anything else, it might well be broken.

@cshung cshung force-pushed the public/dev/andrewau/decode-genaware-events branch from 99f3669 to 2977f01 Compare August 28, 2020 22:55
@cshung cshung force-pushed the public/dev/andrewau/decode-genaware-events branch from 2977f01 to cadca24 Compare November 3, 2020 21:04
@cshung cshung force-pushed the public/dev/andrewau/decode-genaware-events branch from e3d47ed to 877c4da Compare November 17, 2020 18:26
@cshung
Copy link
Contributor Author

cshung commented Nov 17, 2020

Hi @brianrob, can I get this reviewed and merged, please?

@brianrob brianrob merged commit 3a9b3aa into microsoft:master Nov 24, 2020
@cshung cshung deleted the public/dev/andrewau/decode-genaware-events branch November 25, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants