Display JIT Allocated Heap Size #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianrob
reviewed
Oct 14, 2020
Member
brianrob
left a comment
brianrob
left a comment
There was a problem hiding this comment.
@kunalspathak, this is looking good. A few comments/questions.
Contributor
Author
|
@brianrob - I think this should be ready for review. |
20 tasks
brianrob
approved these changes
Nov 10, 2020
Member
brianrob
left a comment
brianrob
left a comment
There was a problem hiding this comment.
LGTM. I will merge this once the corresponding runtime change is merged.
Contributor
Author
|
@brianrob - dotnet/runtime#44030 is merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new event
MethodJitMemoryAllocatedForCodein dotnet/runtime#44030 to log the JIT 's memory request for code. This PR displays that information in PerfView.Here is the screenshot: