Skip to content

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Jul 16, 2024

Fixes builds on case-sensitive systems. The actual DLL in the package is lowercase.

image
/usr/share/dotnet/sdk/8.0.303/Microsoft.Common.CurrentVersion.targets(5270,5): error MSB3030: Could not copy the file "/home/runner/.nuget/packages/microsoft.diagnostics.tracing.traceevent.supportfiles/1.0.28/lib/native/arm64/KernelTraceControl.dll" because it was not found. [/home/runner/work/sentry-dotnet/sentry-dotnet/modules/perfview/src/TraceEvent/TraceEvent.csproj::TargetFramework=netstandard2.0]

@vaind vaind marked this pull request as ready for review July 16, 2024 10:14
@cincuranet
Copy link
Collaborator

@brianrob Do we maybe want to rename the file in the package to have proper casing? Do you see any risk in doing that?

@brianrob
Copy link
Member

@brianrob Do we maybe want to rename the file in the package to have proper casing? Do you see any risk in doing that?

I think this would be fine.

@cincuranet
Copy link
Collaborator

This has been fixed in the package directly. New release (and hence new support files) will contain proper casing. Thanks for bringing that up!

@cincuranet cincuranet closed this Sep 12, 2024
@cincuranet
Copy link
Collaborator

#2115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants