Skip to content

Fix memory leak when TraceEvent modifies the _eventRecord->ExtendedData field #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianrob merged 1 commit into from
Oct 1, 2024
Merged

Fix memory leak when TraceEvent modifies the _eventRecord->ExtendedData field #2114

brianrob merged 1 commit into from
Oct 1, 2024

Conversation

@filipnavara
Copy link
Contributor

@filipnavara filipnavara commented Sep 25, 2024

@noahfalk
Copy link
Member

noahfalk commented Oct 1, 2024

Thanks @filipnavara!

@brianrob - you good if we merge this?

brianrob
brianrob approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@brianrob brianrob merged commit e343a0c into microsoft:main Oct 1, 2024
@bruno-garcia bruno-garcia mentioned this pull request Oct 1, 2024
Closed
@vaind vaind mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianrob brianrob brianrob approved these changes

@noahfalk noahfalk noahfalk approved these changes

+1 more reviewer

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@filipnavara @noahfalk @bruno-garcia @brianrob