Skip to content

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 17, 2025

Introduced in microsoft/playwright#35136, this allows all ports to reuse the implementation.

  • It was important to make sure we do not await for the regex before waiting for events in methods like WaitForRequest or WaitForNavigation. Otherwise, we could have missed an event.
  • This required introducing an async predicate into WaitForEventAsync helpers.
  • WaitForURL turned out to be tricky with multiple tasks and cancellations.
  • Breaking change: Page.Frame() does not support globs anymore.

@dgozman dgozman requested a review from mxschmitt April 17, 2025 15:05
@dgozman dgozman closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant