Skip to content

Fix InvalidOperationException in Selectors when running parallel tests #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 3 commits into from
Jul 30, 2025
Merged

Fix InvalidOperationException in Selectors when running parallel tests #3208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d78ec5
Initial plan
Copilot Jul 23, 2025
118c40a
Fix thread safety issue in Selectors.cs by creating snapshots before …
Copilot Jul 23, 2025
f0012d0
Remove test file - fix is complete
Copilot Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Playwright/Core/Selectors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public async Task RegisterAsync(string name, SelectorsRegisterOptions? options =
{
engine["contentScript"] = options.ContentScript;
}
foreach (var context in _contextsForSelectors)
foreach (var context in _contextsForSelectors.ToArray())
{
await context.SendMessageToServerAsync("registerSelectorEngine", new Dictionary<string, object?>
{
Expand All @@ -67,7 +67,7 @@ public void SetTestIdAttribute(string attributeName)
{
Locator.SetTestIdAttribute(attributeName);
_testIdAttributeName = attributeName;
foreach (var context in _contextsForSelectors)
foreach (var context in _contextsForSelectors.ToArray())
{
context.SendMessageToServerAsync(
"setTestIdAttributeName",
Expand Down
Loading