Skip to content

feat: added Request.postDataBuffer #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

feat: added Request.postDataBuffer #150

merged 1 commit into from
Aug 5, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Aug 5, 2020 •
edited
Loading

Relates #144

@mxschmitt mxschmitt force-pushed the feature/requestpostDataBuffer branch from d65dc8b to e02c8e7 Compare August 5, 2020 20:09
@coveralls
Copy link

coveralls commented Aug 5, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 196845337

  • 14 of 15 (93.33%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 89.902%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/sync_api.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
playwright/sync_api.py 2 68.36%
Totals Coverage Status
Change from base Build 196736572: -0.04%
Covered Lines: 3659
Relevant Lines: 4070
💛 - Coveralls

pavelfeldman
pavelfeldman reviewed Aug 5, 2020
View reviewed changes
playwright/network.py

@property
def postDataBuffer(self) -> Optional[bytes]:
b64_content = self._initializer.get("postData")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use it in postData ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mxschmitt mxschmitt force-pushed the feature/requestpostDataBuffer branch from e02c8e7 to 4f81823 Compare August 5, 2020 21:48
@mxschmitt mxschmitt merged commit 0f6451e into microsoft:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mxschmitt @coveralls @pavelfeldman