Skip to content

fix(launcher): make PrintDeps.exe path configurable #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020
Merged

fix(launcher): make PrintDeps.exe path configurable #3311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(launcher): make PrintDeps.exe path configurable
  • Loading branch information
@mxschmitt
mxschmitt committed Aug 5, 2020
commit 552fafff2c7355e955bab16d0e0f9ecde7f29c1b
3 changes: 2 additions & 1 deletion src/server/validateDependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ async function executablesOrSharedLibraries(directoryPath: string): Promise<stri

async function missingFileDependenciesWindows(filePath: string): Promise<Array<string>> {
const dirname = path.dirname(filePath);
const {stdout, code} = await spawnAsync(path.join(__dirname, '../../bin/PrintDeps.exe'), [filePath], {
const printDepsWindowsExecutable = process.env.PW_PRINT_DEPS_WINDOWS_EXECUTABLE || path.join(__dirname, '../../bin/PrintDeps.exe');
const {stdout, code} = await spawnAsync(printDepsWindowsExecutable, [filePath], {
cwd: dirname,
env: {
...process.env,
Expand Down