Skip to content

Conversation

@gwennlbh
Copy link
Contributor

@gwennlbh gwennlbh commented May 6, 2025

I had to go search this and found out about this way of seeing where the mouse is through #16546

Putting it in the docs will save people some time :)

gwennlbh and others added 2 commits May 9, 2025 15:16
Co-authored-by: Max Schmitt <[email protected]>
Signed-off-by: Gwenn Le Bihan <[email protected]>
Co-authored-by: Max Schmitt <[email protected]>
Signed-off-by: Gwenn Le Bihan <[email protected]>
@agg23
Copy link
Contributor

agg23 commented Jun 4, 2025

@gwennlbh, this PR is stalled as your change isn't passing our linter. It looks like your link paths aren't correct.

@gwennlbh
Copy link
Contributor Author

gwennlbh commented Jun 5, 2025

ok so i figured it out -- i see two problems with the linter:

  1. having multiple links triggers weird messages from the linter:

    docs/src/api/class-mouse.md references to '/home/runner/work/playwright/playwright/docs/src/running-tests.md#debug-tests-with-the-playwright-inspector' as 'Trace viewer](../trace-viewer-intro.md) or [Playwright Inspector' which does not exist

  2. you can't have a hash to link to a specific section, the linter thinks the link is wrong

@gwennlbh
Copy link
Contributor Author

gwennlbh commented Jun 5, 2025

@microsoft-github-policy-service agree

@github-actions

This comment has been minimized.

@agg23
Copy link
Contributor

agg23 commented Jun 6, 2025

  1. I believe your path lookup is failing.

  2. I don't understand. We use anchors all of the time

    The following example demonstrates extending the `TestFixtures` class from the [Test Runners example](./test-runners#running-tests-in-parallel) with a new fixture that contains some common `AxeBuilder` configuration.

@gwennlbh
Copy link
Contributor Author

gwennlbh commented Jun 6, 2025

  1. I believe your path lookup is failing.

latest lint error comes from a diff in the generated .d.ts files that include docs as part of their docstring comments, this is a clean tree check that runs after lints, so the path lookup does not fail anymore

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [chromium] › headerView.spec.tsx:46:1 › should toggle filters @web-components-html-reporter
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39318 passed, 818 skipped
✔️✔️✔️

Merge workflow run.

@gwennlbh gwennlbh requested a review from mxschmitt June 6, 2025 14:41
@mxschmitt mxschmitt merged commit 0ace76a into microsoft:main Jun 6, 2025
28 of 29 checks passed
@mxschmitt
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants