chore: hide locator(':root') in Steps for toHaveTitle/URL #36213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
steps-page-assertions
branch
from
52f8658 to
8ae5354
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
steps-page-assertions
branch
2 times, most recently
from
c291c5b to
5481c54
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
steps-page-assertions
branch
from
5481c54 to
134fcce
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Jun 11, 2025
| header = colors.red(`Timed out ${timeout}ms waiting for `) + header; | ||
| if (locator) | ||
| header += `Locator: ${String(locator)}\n`; | ||
| if (locatorOrPage) |
Contributor
There was a problem hiding this comment.
I can't see this new suffix in any tests, and so I think we don't need it :)
Contributor
Author
There was a problem hiding this comment.
We test it here:
| this: ExpectMatcherState, | ||
| matcherName: string, | ||
| receiver: Locator, | ||
| receiver: Locator | Page, |
Contributor
There was a problem hiding this comment.
I guess we should pass receiverLabel: 'page' whenever we pass a page, or better yet auto-detect it here? Perhaps default to receiverType.toLowerCase()?
mxschmitt
force-pushed
the
steps-page-assertions
branch
from
134fcce to
60314ca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
steps-page-assertions
branch
from
c3aaeac to
2e32732
Compare
dgozman
approved these changes
Jun 16, 2025
Contributor
Test results for "tests 1"6 flaky39401 passed, 822 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it looked like:
Now it looks like: