chore: browserserver, design two #36382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2025
Contributor
Test results for "tests 1"4 flaky39450 passed, 823 skipped Merge workflow run. |
dgozman
approved these changes
Jun 20, 2025
Contributor
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Let's follow up with npx playwright open.
|
|
||
| debugLogger.log('server', `[${id}] engaged connect mode`); | ||
|
|
||
| let browser = this._playwright.allBrowsers().find(b => b.options.name === browserName); |
Contributor
There was a problem hiding this comment.
It seems like we should compare launchOptions like we do for reuse.
Member
Author
There was a problem hiding this comment.
that'd require MCP to know the launchOptions of the test runner. unsure if this is right
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second revision of the browser server sketch. It facilitates sharing browser amongst Playwright MCP, the VS Code Extension and CLI Clients like
npx playwright openornpx playwright test.Implemented using a new connection mode that's similar to "reuse browsers", but that doesn't close anything on connect. For now, you can only specify
connect=firstto get access to the first browser.Demo still works the same as in the previous revision:
Screen.Recording.2025-06-16.at.15.01.37.mov
You can also do
nxp playwright openwith thePW_BROWSER_SERVERenv var. There's no support in test runner yet.See microsoft/playwright-mcp#579 and microsoft/playwright-vscode#647 for the other side of the demo.