chore(aria): don't ignore top-level containerMode
#36471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
commented
Jun 27, 2025
| convertSeq(fragment, yamlDoc.contents as yamlTypes.YAMLSeq); | ||
| if (errors.length) | ||
| return { errors, fragment: emptyFragment }; | ||
| if (fragment.children?.length === 1) |
Member
Author
There was a problem hiding this comment.
Instead of deleting, doing && !fragment.containerMode would also solve the issue. But my understanding is that this line is just a tiny optimisation anyway, so I removed the complexity instead.
Member
Author
There was a problem hiding this comment.
Turns out it's not a tiny optimisation! It has an impact on whether we match the element itself or its parent, as is evidenced by the failing tests debug-controller.spec.ts:286 cli-codegen-aria.spec.ts:76 trace-viewer.spec.ts:1189. I turned it into the other thing.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Jun 27, 2025
dgozman
approved these changes
Jun 27, 2025
Contributor
Test results for "tests 1"4 flaky46467 passed, 931 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36456