-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Support React Native New Architecture #2792
Conversation
Support react-native new architecture
@microsoft-github-policy-service agree |
Hello @CHOIMINSEOK thank you for the contribution, as you probably saw we won't support NA for RNCP but i encourage you to use it on your fork. I've also tried testing the changes and can't seem to fetch the changes from codepush server. I'll attach the logcat output for reference. |
* update readme * update setup guide * unnecessary setup guide * update setup guide * add expo guideline
For anyone who needs https://github.com/CodePushNext/react-native-code-push |
Credits to @CHOIMINSEOK and @kmsbernard for their PR on the original repo microsoft/react-native-code-push#2792
Credits to @CHOIMINSEOK and @kmsbernard for their PR on the original repo microsoft/react-native-code-push#2792
Credits to @CHOIMINSEOK and @kmsbernard for their PR on the original repo microsoft/react-native-code-push#2792
Hello @CHOIMINSEOK, we added new arch support to AppZung thanks to your PR. For the problem of multiple instantiation you may simply use a singleton, here is a commit that does that. Our vision is to keep compatibility with the old CodePush API so that our users may switch back/to our managed solution or Microsoft's open source codepush server (from which our backend is not based on since it is not production ready). It is a drop-in replacement for AppCenter CodePush developed for the clients of our dev consulting activities (mostly established businesses). It is now open publicly too. It provides a very easy migration from AppCenter (one command migration of your AppCenter projects and deployment keys), feature-parity with the original module, EU hosting, fast worldwide CDN. We have some innovative and exciting ideas planned for the near future too ;) Since we maintain and enhance the service for our private clients, you are pretty much guaranteed to have a lasting service. Cost-wise it is an affordable solution compared to Expo-updates. |
@kmsbernard and I have updated react-native-code-push to support the new architecture of React Native. We believe the best way to deploy these updates is through this main repository, and we are submitting this pull request to synchronize the following changes with the upstream master branch. Please let us know if you are open to new contributions. We are also committed to maintaining this code going forward.
Changes included in this pull request:
1. Support for the new architecture on Android and iOS
JsBundleLoader
is managed byReactHostDelegate
. Replace theJsBundleLoader
inReactHostDelegate
using reflection when new architecture is on. Most of the relevant changes can be found in this commit.2. Fix for E2E test scripts to support the new architecture