Skip to content

Refactor how focusable is handled in RCTView #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Refactor how focusable is handled in RCTView #1437

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac20269
Update RCTView.m
Saadnajmi Sep 19, 2022
dc253ab
Refactor
Saadnajmi Oct 24, 2022
5ece783
Merge branch 'main' into Saadnajmi-patch-1
Saadnajmi Oct 24, 2022
107b686
Don't need to override `canBecomeKeyView`
Saadnajmi Oct 25, 2022
b9cc0c6
Update RCTView.m
Saadnajmi Oct 26, 2022
58a401d
Update RCTView.m
Saadnajmi Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor
  • Loading branch information
@Saadnajmi
Saadnajmi committed Oct 24, 2022
commit dc253abba0be9ef8919197331d573243e549f1f9
6 changes: 5 additions & 1 deletion React/Views/RCTView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,9 +1440,13 @@ - (void)mouseUp:(NSEvent *)event
}
}

- (BOOL) canBecomeKeyView {
return ([self focusable] && [NSApp isFullKeyboardAccessEnabled]) || [super canBecomeKeyView];
}

- (BOOL)acceptsFirstResponder
{
return [self focusable] || [super acceptsFirstResponder];
return [self focusable] || [super acceptsFirstResponder];
}

- (void)updateTrackingAreas
Expand Down