Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fabric] Fixes to core fabric components #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[fabric] Fixes to core fabric components #2117
Changes from 1 commit
c437f2f355f73b35259d8db854b2de055ae71fae191b11edc53f631fb53775d5ace62928a761f80b6b440c79cb264b4213f74997f474fcb9fadf8a899ae714e8e940da1602d3d7d97d1f84e599c681a1db2ac7c195fddef7b11d431aeb0686f29763e017f323c8cdb694e40904c79515042fb07ea1810f6af8d4dea8abc6d7434f264cd166737ac483ef4f803d5deb8950074e49b4cceed98b65070fd4e60d4b5d94acea929de265c17a1dc2186042403abec00e38a2160454fb5b4ba9b121fc32c064599be4bfb53d011581a1e3d7ecb2f61b5364e6f05e548b630fb8c6444a699610c547d683ba2378abb12e7ab0e32bb62470f4ed667846b829273a14d9b398ed3f254f4dbd6b404ca430e28cc052f5fe4989a6b0fd9cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Summary: This diff conditionally sets the CALayer masksToBounds based on the clipsToBounds RN property so that the content of the view would be clipped by the view border. Test Plan: - Run Zeratul with Fabric enabled - Check that the profile pictures with no status indicator are clipped by the half size border radius set on the parent view. | Before | After | |--| | {F1090251649} | {F1090249259} | Reviewers: shawndempsey, chpurrer, #rn-desktop Reviewed By: chpurrer Differential Revision: https://phabricator.intern.facebook.com/D49239973Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing