Skip to content

fix(fabric): cherry-pick some View related fixes #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2024
Merged

fix(fabric): cherry-pick some View related fixes #2281

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba0ed56
[fabric] Fix hit testing calls going through LegacyViewManagerInterop…
Sep 8, 2023
e665550
[fabric] Add support for clipsToBounds to RCTViewComponentView
Sep 13, 2023
5aacc3e
[fabric] Fix events being dispatched to wrong react component for Pap…
Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[fabric] Add support for clipsToBounds to RCTViewComponentView 
Summary: This diff conditionally sets the CALayer masksToBounds based on the clipsToBounds RN property so that the content of the view would be clipped by the view border.

Test Plan:
- Run Zeratul with Fabric enabled
- Check that the profile pictures with no status indicator are clipped by the half size border radius set on the parent view.

| Before | After |
|--|
|  {F1090251649}  |  {F1090249259}  |

Reviewers: shawndempsey, chpurrer, #rn-desktop

Reviewed By: chpurrer

Differential Revision: https://phabricator.intern.facebook.com/D49239973
  • Loading branch information
@Saadnajmi
Nick Lefever authored and Saadnajmi committed Nov 15, 2024
commit e6655507185b3988d2f4ab4828d1e107cf44c247
5 changes: 5 additions & 0 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,11 @@ - (void)invalidateLayer
return;
}

#if TARGET_OS_OSX // [macOS
// clipsToBounds is stubbed out on macOS because it's not part of NSView
layer.masksToBounds = self.clipsToBounds;
#endif // macOS]

const auto borderMetrics = _props->resolveBorderMetrics(_layoutMetrics);

// Stage 1. Shadow Path
Expand Down