Skip to content

Merge from upstream through 2020-05-28 #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 423 commits into from
Aug 16, 2021
Merged

Merge from upstream through 2020-05-28 #811

Changes from 235 commits
Commits
Show all changes
423 commits
Select commit Hold shift + click to select a range
1787c16
Remove `docs` from `jscodeshift`
cpojer May 3, 2020
8ad8107
iOS: when the bridge has been invalidated, NativeModule lookup should…
fkgozali May 3, 2020
87d000f
Fix invalid type annotations
cpojer May 3, 2020
9cdc19a
Fixes TextInput shaking when typing Chinese (#28805)
zhongwuzw May 4, 2020
7bd694f
VirtualizedList: Migrate to React.Context
yungsters May 4, 2020
ddea7c7
VirtualizedList: Remove `PropTypes` Dependency
yungsters May 4, 2020
8acb2b3
Remove `@babel/preset-env`
cpojer May 4, 2020
577fdea
Add prepareForReuse to RCTSafeAreaViewComponentView
sammy-SC May 4, 2020
ced959b
chore: remove Kotlin version from the default template (#28626)
grabbou May 4, 2020
d815be1
Fix Optimized Differ (was generating extraneous Create mutations)
JoshuaGross May 4, 2020
7f2515e
Add warning when scrollRef does not have a scrollTo method
kacieb May 4, 2020
30a89f3
Don't use #import in C++ Code (#28825)
NickGerleman May 4, 2020
ca144fc
Fix unit test compilation on Android
JoshuaGross May 5, 2020
aae38c3
Support calling LayoutAnimation APIs in Fabric from JS
JoshuaGross May 5, 2020
bb5d043
Differ: fix TinyMap to prevent possible crashes in `find()` and `begi…
JoshuaGross May 5, 2020
0348953
Allow passing partial contentOffset to ScrollView on Android (#28817)
janicduplessis May 5, 2020
4f5a092
Pass initial props to WrapperComponent
rubennorte May 5, 2020
1740233
Upgrade to Jest 26
cpojer May 5, 2020
4459c08
Make column match fuzzy
willholen May 5, 2020
de7f69a
Fix type of exported Touchables: ComponentType -> AbstractComponent (…
draperunner May 5, 2020
e8060ae
Import folly and adjust whitespace to match old codegen
hramos May 5, 2020
edfd965
Update native module specs
May 6, 2020
10314fe
Smoother scrolling in ScrollView, HorizontalScrollView
JoshuaGross May 6, 2020
530dffa
Cleanup unused dependencies
cpojer May 6, 2020
b0d0e51
iOS: Animated image should animate at the same speed regardless of fr…
p-sun May 6, 2020
5066b66
LogBox - Always display the first fatal error
rickhanlonii May 6, 2020
41f0d9b
Rename error titles
rickhanlonii May 6, 2020
de667ff
Moved some NativeModule JS specs to OSS
fkgozali May 6, 2020
0c2c4bf
Deploy Flow v0.124.0 to xplat/js
nmote May 6, 2020
d14b89b
RN: Workaround Fabric + Virtual Text Press Bug
yungsters May 6, 2020
fa5b4c9
Fabric: Backward-compatible behaviour of `measureInWindow` and `measure`
shergin May 6, 2020
21d7a35
Upgrade to Yargs 15
cpojer May 6, 2020
ff0c625
Ez Extend logging of Fabric
mdvacca May 6, 2020
5c48c94
Fix measureLayout function for Virtual Nodes
mdvacca May 6, 2020
ca105f8
Update cocoapods (#28833)
May 6, 2020
d76e03f
Fabric: Introducing `RunLoopObserver`
shergin May 7, 2020
025b6a7
Fabric: Cross-platform implementation of `SynchronousEventBeat` and `…
shergin May 7, 2020
f4815fb
third-party | Move glog from xplat/third-party to third-party and cre…
nlutsenko May 7, 2020
851644c
Fix Animated type
rijn May 7, 2020
e566c7e
Add virtual destructor to JSError
javache May 7, 2020
26c120c
Handle initialProps as optional in renderApplication
rubennorte May 7, 2020
7bb1c4e
Enable with CocoaPods `:configuration` (#28796)
alloy May 7, 2020
16ea9ba
Support excluding multiple platforms.
joaovieira May 7, 2020
4e59508
Extend ParagraphAttribute to store the includeFontPadding prop
mdvacca May 8, 2020
561a97f
Extend Text measurement to support includeFontPadding prop
mdvacca May 8, 2020
11b9bad
Small refactor on text measure method
mdvacca May 8, 2020
853dc04
Handle optional return types/values
hramos May 8, 2020
6e88ab6
Avoid redefining id when a property is named 'id'
hramos May 8, 2020
14a0f3f
Eager initialize Fabric Android classes
mdvacca May 8, 2020
938aa86
Remove Hermes.setPauseOnLoad message
willholen May 8, 2020
bf837d6
Add support for Debugger.setInstrumentationBreakpoint
willholen May 8, 2020
164d47f
label react-native-github targets
fkgozali May 8, 2020
91a49d8
Add script to generate native modules specs with react-native-codegen
hramos May 8, 2020
69ce9c2
Update .gitignore (#28789)
enesozturk May 8, 2020
c67e1fe
Codegen: Add prepublish script to build Flow files (#28827)
empyrical May 8, 2020
77d1380
Remove RCTLogError from RCTScrollViewManager.calculateChildFrames
sammy-SC May 8, 2020
13ee5c4
Enable animations in bridgeless mode on iOS
May 8, 2020
a4a47b9
Expose RuntimeExecutor on CatalystInstance (#28851)
May 8, 2020
f535c8b
Inject ImagePipeline into FrescoModule
mdvacca May 8, 2020
aece57b
Fabric: Calling JSVM GC on memory pressure event on iOS
shergin May 9, 2020
a1ac251
TextInput: Default `blurOnSubmit` in JS
yungsters May 10, 2020
03ef81b
Fix taps not working after scrolling / scroll position not being upda…
JoshuaGross May 10, 2020
af1fe62
Fabric: Changes in UIManager::getNewestCloneOfShadowNode to make it s…
shergin May 10, 2020
6044026
Fabric: Making `UIManager::getRelativeLayoutMetrics` safer
shergin May 10, 2020
0d2fcb1
Fabric: Making `UIManager::getNewestCloneOfShadowNode` even more safer
shergin May 10, 2020
4971916
Fabric: Checks for corner cases in UIManager::getNewestCloneOfShadowNode
shergin May 10, 2020
e57a2d8
OSS: fixed incorrect license headers on some files
fkgozali May 10, 2020
b65b00a
Fabric: Fixed incorrect name of the prop value `justifyContent=space-…
shergin May 11, 2020
ebdd59a
Fabric: Initializing EventBeat::OwnerBox with non-null value ahead of…
shergin May 11, 2020
f05fff6
Fabric: Using `PlatformRunLoopObserver` instead of `MainRunLoopEventB…
shergin May 11, 2020
4b956fe
Fix skewX/skewY/perspective/matrix on iOS (#28863)
wcandillon May 11, 2020
797367c
Fix skewX on Android and in the JS decomposition (#28862)
wcandillon May 11, 2020
d54113d
implemented showSoftInputOnFocus for iOS (#28834)
gurs1kh May 11, 2020
51740f8
Fabric: Support for sync `RuntimeExecutor` in `executeSynchronouslyOn…
shergin May 11, 2020
03ccb63
Use plugin architecture for Paragraph component
sammy-SC May 11, 2020
5223127
Use plugins for TextInput component
sammy-SC May 11, 2020
b87d67e
Use plugins for View component
sammy-SC May 11, 2020
dd7b671
Move SegmentedControl components to separate file and make them funct…
sammy-SC May 11, 2020
cde82b5
Add comments to a test case in LayoutableShadowNodeTest
sammy-SC May 11, 2020
3c90134
xplat code ownership
fkgozali May 11, 2020
dba5887
Always run the momentum scroll Runnable so scroll position is updated…
JoshuaGross May 11, 2020
6c4224e
Use UIManagerHelper to access EventDispatcher in ReactViewManager
May 12, 2020
d30c920
Mention using bundler to install cocoapods in RNTester README (#28873)
janicduplessis May 12, 2020
8f90ce2
Break retain cycle in RCTLegacyViewManagerInteropCoordinator
sammy-SC May 12, 2020
63099c4
Migrate Android view managers to type-safe commands generated by JS c…
luluwu2032 May 12, 2020
9b53591
Add package name / bundle ID to bundle URL in development
motiz88 May 12, 2020
b4785e5
Forward all bundle URL params through HMR and bundle splitting
motiz88 May 12, 2020
8ffa180
imp: Add titlePlaceholder in template.config.js (#26218)
Esemesek May 12, 2020
43de8ea
Fix opacity not being animated on Text component
sammy-SC May 12, 2020
91468b7
Download image of size based on image view size, not image size
sammy-SC May 12, 2020
f78bd0e
Fabric: Fixed incorrect memory management in Scheduler
shergin May 12, 2020
649e1b7
Fixing typo in comment (#28882)
potlov May 12, 2020
e5a6655
iOS: Fix Animated image crash when CADisplayLink target in RCTWeakPro…
p-sun May 13, 2020
df08d65
Disable animations on Android again
May 13, 2020
b01fcee
Get redbox working in bridgeless mode, disable logbox
May 13, 2020
94c45af
Add dark mode to loading progress
rickhanlonii May 13, 2020
774ebd9
Cleanup logbox imports
May 13, 2020
e3f4a7b
Fix precision of TextInlineViews in Android
mdvacca May 13, 2020
77ef8f8
When debugger is attached continue to receive console messages
MartinSherburn May 13, 2020
d9593ae
Add support for ScrollView.centerContent in Fabric
sammy-SC May 13, 2020
6610327
Pressable: Rename pressRectOffset to pressRetentionOffset to be consi…
elicwhite May 13, 2020
179b53b
Back out "Fabric: Calling JSVM GC on memory pressure event on iOS"
shergin May 13, 2020
d269844
LayoutAnimations: have each Props struct do its own interpolation
JoshuaGross May 13, 2020
6570f78
Extend ReactShadowNode API to expose flex props
mdvacca May 13, 2020
0aac4c3
Fabric: Unifying interface of stub TextLayoutManager with actual ones
shergin May 13, 2020
d0c4c5e
Delete playTouchSound from UIManagerModule
mdvacca May 14, 2020
0199a03
Revisit deprecated methods in UIManagerModule and update javadoc
mdvacca May 14, 2020
c3a3d42
Fix dev tool hotkets in RNTester
rickhanlonii May 14, 2020
0486640
Introduce NativeModulePerfLogger
RSNara May 14, 2020
c98f36c
Switch TurboModules over to NativeModulePerfLogger
RSNara May 14, 2020
0b7bcd3
Instrument RCTModuleData create
RSNara May 14, 2020
c3783b5
Instrument module create
RSNara May 14, 2020
9f310a2
Instrument JS requires
RSNara May 14, 2020
bf0e516
Instrument async method call batch preprocessing
RSNara May 14, 2020
0b8a82a
Instrument sync and async method calls (#28893)
RSNara May 14, 2020
16d1520
Remove branching for optimized differ QE
sammy-SC May 14, 2020
5c0a3a6
throw std::logic_error instead of aborting the process and convert to…
SidharthGuglani-zz May 14, 2020
060250d
Add support for ScrollView.contentOffset
sammy-SC May 14, 2020
5c60247
Use east const in ScrollViewProps
sammy-SC May 14, 2020
a7bbc85
Use vector.empty() to check for emptyness
sammy-SC May 14, 2020
eb12cb5
Support interpolating `transform` View property
JoshuaGross May 14, 2020
9f3c7af
Rename <ReactCommon/NativeModulePerfLogger.h> to <reactperflogger/Nat…
RSNara May 15, 2020
aba321b
Create new Feature flag to eager initialize Fabric
mdvacca May 15, 2020
756eec6
Implement eager initialization of Fabric
mdvacca May 15, 2020
cf171e4
Extend Binding to log only when a MC is enabled
mdvacca May 15, 2020
84bca09
Fix position of TextInlineViews when nesting multiple Text components
mdvacca May 15, 2020
2b0208b
Revert D21585006: Rename <ReactCommon/NativeModulePerfLogger.h> to <r…
mendoncakeegan May 15, 2020
505441f
JS: Fix Spelling of JavaScript
yungsters May 15, 2020
c2c0581
Enabling [-Werror,-Wunused-property-ivar] (#28895)
aditya7fb May 15, 2020
452cb9a
Add support for Debugger.runIfWaitingForDebugger
willholen May 15, 2020
6cba4d2
iOS: Fix image instrumentation lifecycle on image cancel
p-sun May 15, 2020
eb2a561
Rename <ReactCommon/NativeModulePerfLogger.h> to <reactperflogger/Nat…
RSNara May 15, 2020
1a218e5
Detect recoverable cases where SendAccessibilityEvent exceptions don'…
JoshuaGross May 16, 2020
480fc28
FabricUIManager should only swallow exceptions related to ViewCommands
JoshuaGross May 16, 2020
4001966
Move Size check before accessing type of transform
axe-fb May 16, 2020
f24b815
use xplat BUCK attribution
fkgozali May 16, 2020
8d548d8
Create new ReactFlag to configure initialization of Fabric
mdvacca May 16, 2020
6a96a9f
Use MC to Start Fabric surfaces using layoutMetrics or not
mdvacca May 16, 2020
b72d676
Fabric: Automatic removing outstanding Surface on Scheduler destructi…
shergin May 17, 2020
8ac467c
Pressable: Add Support for Inspector Overlay
yungsters May 18, 2020
7b61a96
set`NSAllowsArbitraryLoads` to false by default in template (#28885)
wddwycc May 18, 2020
a2e46e4
Extends view flattening algorithm to support flattening of absolute p…
mdvacca May 18, 2020
b4f4f2d
Update Hermes attribution labels
zlern2k May 18, 2020
656db78
Fabric: Changes in LayoutableShadowNodeTest
shergin May 18, 2020
caab26e
Fabric: Refinement of `LayoutableShadowNode::getRelativeLayoutMetrics`
shergin May 18, 2020
dafa975
Fabric: Simplification of `UIManager::getRelativeLayoutMetrics`
shergin May 18, 2020
a011eaf
Basic implementation of ARTSurfaceView
mdvacca May 18, 2020
12fee9a
Create basic implementation of Shape
mdvacca May 18, 2020
54adda6
Basic implementation of ARTGroupProps
mdvacca May 18, 2020
7929f67
Basic implementation of ARTText
mdvacca May 18, 2020
1f95c9b
iOS: Fix logging lifecycle when image is scrolled out and immediately…
p-sun May 18, 2020
04b8c9c
Delete local data from Fabric android
mdvacca May 19, 2020
c8ed2db
get ripple drawables by id (#28600)
vonovak May 19, 2020
4aaf629
Pressable: Minimum Press Duration
yungsters May 19, 2020
f0bf4b0
Add possibility to disable buttons in action sheet ios (#28792)
lukewalczak May 19, 2020
37e7b41
deploy Flow 0.125.1 to xplat
mvitousek May 19, 2020
f9e4e24
Prevent SafeAreaView from reporting same size twice
sammy-SC May 19, 2020
351a9f1
Copy alreadyAppliedPadding when cloning SafeAreaViewShadowNode
sammy-SC May 19, 2020
afad239
remove suppress_comments from xplat flowconfigs
May 19, 2020
8ef0f1d
Fix thrown GradleScriptExceptions
May 19, 2020
c8d678a
Revert D21396409: Add possibility to disable buttons in action sheet ios
shergin May 19, 2020
2c600b7
RN: Persist Asynchronously Consumed Events in Pressability
yungsters May 20, 2020
0a2bb71
docs: mention prettier in eslint-config README (#28930)
exKAZUu May 20, 2020
6b64810
Daily `arc lint --take GOOGLEJAVAFORMAT`
May 20, 2020
6acccae
Add FBRotatablePhotoPlayerView to LegacyInterop whitelist
jimmy623 May 20, 2020
3265519
Fix assignment of hitTestEdgeInsets in RCTViewComponentView
sammy-SC May 20, 2020
e9d6fb2
C++ Fabric Core LayoutAnimations
JoshuaGross May 20, 2020
46310c1
LayoutImplementations: implement all existing animation curves beside…
JoshuaGross May 20, 2020
f0c595b
LayoutAnimations: implement LayoutAnimationStatusDelegate for platfor…
JoshuaGross May 20, 2020
076ba4c
Android-specific LayoutAnimation integration
JoshuaGross May 20, 2020
e781b31
iOS-specific LayoutAnimation integration
JoshuaGross May 20, 2020
3cbafcc
LayoutAnimations: Use Quaternions to interpolate rotation transforms
JoshuaGross May 20, 2020
a799367
LayoutAnimations: allow Paragraph props to be interpolated
JoshuaGross May 20, 2020
adccef7
Revert D21635473: LayoutAnimations: allow Paragraph props to be inter…
mystique1729 May 20, 2020
953c392
Revert D21615829: LayoutAnimations: Use Quaternions to interpolate ro…
mystique1729 May 20, 2020
0803147
Revert D21583932: iOS-specific LayoutAnimation integration
mystique1729 May 20, 2020
70f732d
Revert D21583122: Android-specific LayoutAnimation integration
mystique1729 May 20, 2020
5ae7e4f
Revert D21583109: LayoutAnimations: implement LayoutAnimationStatusDe…
mystique1729 May 20, 2020
6a15d74
Revert D21587648: LayoutImplementations: implement all existing anima…
mystique1729 May 20, 2020
eb504e6
Revert D17486030: C++ Fabric Core LayoutAnimations
mystique1729 May 20, 2020
2e756e0
Remove flow-node requirement from native modules codegen script
hramos May 21, 2020
3331962
C++ Fabric Core LayoutAnimations
JoshuaGross May 21, 2020
8d2c1f6
LayoutImplementations: implement all existing animation curves beside…
JoshuaGross May 21, 2020
eb9b2ce
LayoutAnimations: implement LayoutAnimationStatusDelegate for platfor…
JoshuaGross May 21, 2020
483f84e
Android-specific LayoutAnimation integration
JoshuaGross May 21, 2020
73995cf
iOS-specific LayoutAnimation integration
JoshuaGross May 21, 2020
3f9fad1
LayoutAnimations: Use Quaternions to interpolate rotation transforms
JoshuaGross May 21, 2020
c75e8ae
LayoutAnimations: allow Paragraph props to be interpolated
JoshuaGross May 21, 2020
4830085
Guard all NativeModulePerfLogger calls with a null check
RSNara May 21, 2020
192bea1
Create classes to represent C++ state of ART
mdvacca May 21, 2020
493d616
Create internal State of ART based on Shadow Nodes
mdvacca May 21, 2020
b7ab3aa
Integrate State into ARTSurfaceViewShadowNode
mdvacca May 21, 2020
0305ff8
Integrate ElementType Enum into state
mdvacca May 21, 2020
21afa62
Serialize ART state into folly::dynamic
mdvacca May 21, 2020
745ff10
Prevent ABA problem during YogaLayoutableShadowNode cloning
sammy-SC May 21, 2020
7e343c8
Daily `arc lint --take CLANGFORMAT`
May 21, 2020
6626b84
Fix order in which views are mounted in RCTLegacyViewManagerInteropCo…
sammy-SC May 21, 2020
43d65ed
Separate event dispatchers to ivars instead of array
sammy-SC May 21, 2020
b31149c
Introduce BatchedEventQueue::enqueueUniqueEvent
sammy-SC May 21, 2020
43c161c
Touchable: Revert `minPressDuration` on Legacy Components
yungsters May 21, 2020
e85118c
update internal code attribution
fkgozali May 22, 2020
b7e8f66
Fix imports in `RCTUtilsUIOverride.h` (#28946)
Fanghao May 22, 2020
8888664
Refactor types of ART Text class
mdvacca May 22, 2020
b8b683d
Serialize ART text components and send data to Android
mdvacca May 22, 2020
cfd2e7d
Add support for Text in ART Fabric Android
mdvacca May 22, 2020
55c3666
Rename Element -> ARTElement
mdvacca May 22, 2020
58a7ddd
Implement equality of ARTElements and use it in ARTState
mdvacca May 22, 2020
19e0b13
Delete unused class
mdvacca May 22, 2020
95546d9
Add ART components into Catalyst app Android
mdvacca May 22, 2020
1b1ebaf
Delete copy constructor and copy assignment operator in ShadowNode
sammy-SC May 23, 2020
60b7a30
Annotate <Image> components in QPL logging using ImageAnalyticsTagCon…
p-sun May 24, 2020
18b3680
Cleanup of RCTTExtInputComponentView.mm
sammy-SC May 26, 2020
8d6cc50
Change jsi::Runtime::lockWeakObject to take a mutable ref
christophpurrer May 26, 2020
0b00d92
Android Animated timing: interface-only
JoshuaGross May 26, 2020
8e13480
Fix NativeAnimatedModule timing for Fabric/Venice(?)
JoshuaGross May 26, 2020
ae7df2d
LayoutAnimations: fail silently instead of redboxing if there's a mis…
JoshuaGross May 26, 2020
68c0edd
Split EventDispatcher into interface and impl (#28983)
May 26, 2020
8b2eb37
C++ LayoutAnimations: solve crash when "animating" virtual views
JoshuaGross May 26, 2020
6ff6a79
Add new swizzle method RCTSwapInstanceMethodWithBlock
rickhanlonii May 27, 2020
6f75065
Remove unused double key press code
rickhanlonii May 27, 2020
6a78b32
Migrate react-native Android tests to Robolectric v4 (#28927)
May 27, 2020
1a77943
Better error message when crashing because of an invalid Remove opera…
JoshuaGross May 27, 2020
c8fed9e
Move TimePickerAndroid to FB internal
May 27, 2020
fd97e95
Upgrade to Babel 7.10
cpojer May 27, 2020
0a12f3e
Always return an EventDispatcher in bridgeless mode
May 27, 2020
bd31416
Reset RootView ID when root view is detached from view hierarchy
JoshuaGross May 27, 2020
97d3abf
Do not use variable types for array elements
hramos May 27, 2020
7e55946
Fix crash introduced by D21735940 in T67525923
JoshuaGross May 27, 2020
8da92d7
Fix crash in removeViewAt by fixing incorrect error-detection
JoshuaGross May 28, 2020
5cde6c5
Back out "Reset RootView ID when root view is detached from view hier…
JoshuaGross May 28, 2020
f2b9ec7
Refactor RCTKeyCommands, allow hotkeys to be used without command key
rickhanlonii May 28, 2020
9bb7e06
Remove calls to AllocationLocationTracker for native memory
May 28, 2020
6f8fc40
Add Fabric logs to TextLayoutManager
mdvacca May 28, 2020
34b23c1
Add new bundle loading strategy in FBiOS behind GK
rickhanlonii May 28, 2020
4b596fd
Extend Text to support measurement of empty Texts
mdvacca May 28, 2020
dc357b8
Revert Virtual Text Press Bug workaround
mdvacca May 28, 2020
3b7679b
Clean up Flow & lint errors
cpojer May 28, 2020
3148d17
Delete ViewPagerAndroid JS and BUCK targets
JoshuaGross May 29, 2020
f438a6e
Delete ReactViewPager
JoshuaGross May 29, 2020
81ec211
Merge commit 'a1ac2518a364ebcd3cc024a22229cadc1791e1c4' into amgleitm…
amgleitman Aug 4, 2021
8fdff7a
Merge commit '2b0208b399b60a892c4220e00749bdfebc95901f' into amgleitm…
amgleitman Aug 9, 2021
1f53841
Merge commit 'b72d6768e0228792a30d1cd3874e99361a3c7f60' into amgleitm…
amgleitman Aug 10, 2021
6b8e88a
Merge commit 'b7e8f667953c2bc65c25b00968051c063a684d01' into amgleitm…
amgleitman Aug 12, 2021
10e672f
Merge commit '1a77943e8bef97e7bee903c7bfcf32c56fb8fab8' into amgleitm…
amgleitman Aug 13, 2021
17a23c3
Update Podfile.lock
amgleitman Aug 13, 2021
f2d13cc
Merge commit 'f438a6e8f60a5cd10b06f19bc5248f5805fbb739' into amgleitm…
amgleitman Aug 13, 2021
1de601a
Replace platform check in RCTUtilsUIOverride.h with direct import of …
amgleitman Aug 14, 2021
c3566d3
Add eager initialization of RCTDevMenu to macOS RNTester
amgleitman Aug 14, 2021
7f3e030
Fix for Android Build Issue after RN64 Merge
Aug 16, 2021
7787840
Merge pull request #2 from msgharpu/android_build_fix
amgleitman Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RNTester/RNTesterPods.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,6 +1558,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 5BEC8567F3741044B6A5EFC5 /* Pods-RNTester.release.xcconfig */;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_CXX_LANGUAGE_STANDARD = "c++14";
CODE_SIGN_ENTITLEMENTS = RNTester/RNTester.entitlements;
Expand Down