-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[0.80][Fabric] Fix UIA Clipped Property for Modal Component #15184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Fixing Clipped Property for Modal Component * Yarn Change * Removed try catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please drop template strings from PR description given for your guidance but not to pollute commit messages.
should be
Which of these would you rather read? Why do we add string which don't make sense to a commit at all? Sections like Testing, These template strings are just noise. Compare these messages with PRs from mature developers and notice the difference: |
Title should be a short summary in imperative mood (Fix, not Fixing or Fixed). A good commit message
Please refer How to Write a Git Commit Message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix aforementioned comments.
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks, it's very readable now :)
Description
Fixing UIA Clipping property for Modal Component.
Cherry-pick cc9d7a0
Type of Change
Bug fix
Why
Will fix the UIA clipping state of Modal Component.
Resolves [microsoft/react-native-gallery/issues/650]
Screenshots
Changelog
Should this change be included in the release notes: yes
UIA Clipping property for Modal Component is fixed.
Microsoft Reviewers: Open in CodeFlow