Skip to content

Conversation

vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Sep 29, 2025

Description

Fixing UIA Clipping property for Modal Component.
Cherry-pick cc9d7a0

Type of Change

Bug fix

Why

Will fix the UIA clipping state of Modal Component.
Resolves [microsoft/react-native-gallery/issues/650]

Screenshots

image

Changelog

Should this change be included in the release notes: yes

UIA Clipping property for Modal Component is fixed.

Microsoft Reviewers: Open in CodeFlow

* Fixing Clipped Property for Modal Component

* Yarn Change

* Removed try catch.
@vineethkuttan vineethkuttan marked this pull request as ready for review September 29, 2025 10:51
@vineethkuttan vineethkuttan requested a review from a team as a code owner September 29, 2025 10:51
@vineethkuttan vineethkuttan changed the title [0.80][[Fabric] Fixing Clipped Property for Modal Component [0.80][Fabric] Fixing Clipped Property for Modal Component Sep 29, 2025
Copy link
Contributor

@protikbiswas100 protikbiswas100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Sep 30, 2025

Please drop template strings from PR description given for your guidance but not to pollute commit messages.

## Description
Fixing UIA Clipping property for Modal Component.
Cherry-pick from cc9d7a0

### Type of Change
_Erase all that don't apply._
- Bug fix (non-breaking change which fixes an issue)

### Why
Will fix the UIA clipping state of Modal Component.

Resolves [microsoft/react-native-gallery/issues/650]

### What
Clipped

## Screenshots
<img width="1570" height="1208" alt="image" src="https://github.com/user-attachments/assets/a5f5dd97-b2ee-44e7-ab6e-f05d69074e69" />

## Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.

_Optional_: Describe the tests that you ran locally to verify your changes.

## Changelog
Should this change be included in the release notes: _yes_

UIA Clipping property for Modal Component is fixed.

 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/react-native-windows/pull/15184)

should be

# Description
Fixing UIA Clipping property for Modal Component.
Cherry-pick cc9d7a0

## Type of Change
Bug fix

## Why
Will fix the UIA clipping state of Modal Component.
Resolves [microsoft/react-native-gallery/issues/650]

# Screenshots
<img width="1570" height="1208" alt="image" src="https://github.com/user-attachments/assets/a5f5dd97-b2ee-44e7-ab6e-f05d69074e69" />

# Changelog
Should this change be included in the release notes: _yes_

UIA Clipping property for Modal Component is fixed.

Which of these would you rather read? Why do we add string which don't make sense to a commit at all? Sections like Testing, Erase all that don't apply (this clearly says not to add itself and other unneeded sections and even that is left out without deletion).

These template strings are just noise. Compare these messages with PRs from mature developers and notice the difference:

#14713 by Andrew
#15013 by Jon

@sundaramramaswamy
Copy link
Contributor

sundaramramaswamy commented Sep 30, 2025

Title should be a short summary in imperative mood (Fix, not Fixing or Fixed).

A good commit message

  • Captures the why (context) not how / what (which git diff can always show)
  • Is succinct.

Please refer How to Write a Git Commit Message.

Copy link
Contributor

@sundaramramaswamy sundaramramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix aforementioned comments.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Sep 30, 2025
@vineethkuttan vineethkuttan changed the title [0.80][Fabric] Fixing Clipped Property for Modal Component [0.80][Fabric] Fix UIA Clipped Property for Modal Component Oct 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Oct 6, 2025
Copy link
Contributor

@sundaramramaswamy sundaramramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sundaramramaswamy sundaramramaswamy Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, it's very readable now :)

@vineethkuttan vineethkuttan merged commit 7ce0f31 into 0.80-stable Oct 8, 2025
91 checks passed
@vineethkuttan vineethkuttan deleted the user/vineeth/fixModalClipping2.0 branch October 8, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants