Skip to content

Today even if classInit wasnt called we used to call class cleanup. f… #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acesiddhu merged 9 commits into from
Feb 20, 2018
Merged

Today even if classInit wasnt called we used to call class cleanup. f… #372

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ebe2ca
Today even if classInit wasnt called we used to call class cleanup. f…
Feb 19, 2018
67c197e
PR comment
Feb 20, 2018
23b237d
fixed a bug and fixed failing tests
Feb 20, 2018
7819037
un did ctest code fixes
Feb 20, 2018
31cfe68
added back a test
Feb 20, 2018
967eb99
more fixes
Feb 20, 2018
ab84619
minor
Feb 20, 2018
91ca2a9
minor
Feb 20, 2018
4874cf2
pr comment
Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more fixes
  • Loading branch information
siddhap committed Feb 20, 2018
commit 967eb99979ae46cac7c962e0d7a9ba6945a5c7a5
6 changes: 0 additions & 6 deletions test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestClassInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,6 @@ public void RunClassCleanupShouldReturnAssertInconclusiveExceptionDetails()
DummyTestClass.ClassCleanupMethodBody = () => UTF.Assert.Inconclusive("Test Inconclusive.");

this.testClassInfo.ClassCleanupMethod = typeof(DummyTestClass).GetMethod("ClassCleanupMethod");
this.testClassInfo.ClassInitializeMethod = typeof(DummyTestClass).GetMethod("ClassInitializeMethod");

this.testClassInfo.RunClassInitialize(this.testContext);

StringAssert.StartsWith(
this.testClassInfo.RunClassCleanup(),
Expand All @@ -377,9 +374,6 @@ public void RunClassCleanupShouldReturnExceptionDetailsOfNonAssertExceptions()
DummyTestClass.ClassCleanupMethodBody = () => { throw new ArgumentException("Argument Exception"); };

this.testClassInfo.ClassCleanupMethod = typeof(DummyTestClass).GetMethod("ClassCleanupMethod");
this.testClassInfo.ClassInitializeMethod = typeof(DummyTestClass).GetMethod("ClassInitializeMethod");

this.testClassInfo.RunClassInitialize(this.testContext);

StringAssert.StartsWith(
this.testClassInfo.RunClassCleanup(),
Expand Down