Skip to content

Base class data rows should not be executed #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayaranigarg merged 6 commits into from
Jan 11, 2019
Merged

Base class data rows should not be executed #546

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d21ba97
Base class data rows should not be executed
jayaranigarg Dec 19, 2018
be0402a
Adding tests
jayaranigarg Dec 24, 2018
1858a3c
PR comments
jayaranigarg Jan 10, 2019
a691dec
Merge branch 'master' into issue458
jayaranigarg Jan 10, 2019
ef523be
Nit
jayaranigarg Jan 10, 2019
7e502d9
Merge branch 'issue458' of https://github.com/jayaranigarg/testfx int…
jayaranigarg Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Nit
  • Loading branch information
@jayaranigarg
jayaranigarg committed Jan 10, 2019
commit ef523bea9826dabe5339de7da48812b77cbe7d3c
2 changes: 1 addition & 1 deletion test/E2ETests/Smoke.E2E.Tests/DataRowTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class DataRowTests : CLITestBase
[TestMethod]
public void ExecuteOnlyDerivedClassDataRowsWhenBothBaseAndDerviedClassHasDataRows()
{
this.InvokeVsTestForExecution(new string[] { TestAssembly }, testCaseFilter: "FullyQualifiedName~DerivedClass");
this.InvokeVsTestForExecution(new string[] { TestAssembly });

this.ValidatePassedTestsContain(
Copy link
Contributor

@singhsarab singhsarab Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this validation change after using the filter ?

Copy link
Member Author

@jayaranigarg jayaranigarg Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By mistake added filter in first test.

"DataRowTestMethod (BaseString1)",
Expand Down