Skip to content

Configuring child domain's appbase to be test source location #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayaranigarg merged 8 commits into from
Nov 26, 2019
Merged

Configuring child domain's appbase to be test source location #659

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
740474b
Correcting error message when dynamic data doen't have any data
jayaranigarg Dec 18, 2018
e34a4c3
Fix merge conflicts
jayaranigarg Apr 30, 2019
c554dd5
Merge remote-tracking branch 'upstream/master'
jayaranigarg Nov 8, 2019
0fef58c
Configuring child domain's appbase to be test source location
jayaranigarg Nov 18, 2019
36d39bc
Nit
jayaranigarg Nov 18, 2019
752baab
Catch typeload exception if TestAssemblySettingsProvider doesn't exist
jayaranigarg Nov 25, 2019
6fc051c
PR comments
jayaranigarg Nov 26, 2019
b0f5851
Nit
jayaranigarg Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correcting error message when dynamic data doen't have any data
  • Loading branch information
@jayaranigarg
jayaranigarg committed Dec 18, 2018
commit 740474b586cfbcd78fe0c2afd59fd2ed5d97c7a8
3 changes: 2 additions & 1 deletion src/TestFramework/MSTest.Core/Attributes/DynamicDataAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ public IEnumerable<object[]> GetData(MethodInfo methodInfo)
}

IEnumerable<object[]> enumerable = obj as IEnumerable<object[]>;
if (enumerable == null)

if (enumerable == null || !enumerable.Any())
{
throw new ArgumentNullException(
string.Format(
Expand Down
37 changes: 35 additions & 2 deletions test/UnitTests/MSTest.Core.Unit.Tests/Attributes/DynamicDataAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,19 @@ public void GetDataShouldThrowExceptionIfPropertyReturnsNull()
ActionUtility.ActionShouldThrowExceptionOfType(action, typeof(ArgumentNullException));
}

[TestFrameworkV1.TestMethod]
public void GetDataShouldThrowExceptionIfPropertyReturnsEmpty()
{
Action action = () =>
{
var methodInfo = this.dummyTestClass.GetType().GetTypeInfo().GetDeclaredMethod("TestMethod5");
this.dynamicDataAttribute = new DynamicDataAttribute("EmptyProperty", typeof(DummyTestClass));
this.dynamicDataAttribute.GetData(methodInfo);
};

ActionUtility.ActionShouldThrowExceptionOfType(action, typeof(ArgumentNullException));
}

[TestFrameworkV1.TestMethod]
public void GetDataShouldThrowExceptionIfPropertyDoesNotReturnCorrectType()
{
Expand Down Expand Up @@ -282,7 +295,7 @@ public static IEnumerable<object[]> ReusableTestDataProperty
}

/// <summary>
/// Gets the reusable test data property.
/// Gets the null test data property.
/// </summary>
public static IEnumerable<object[]> NullProperty
{
Expand All @@ -293,7 +306,18 @@ public static IEnumerable<object[]> NullProperty
}

/// <summary>
/// Gets the reusable test data property.
/// Gets the empty test data property.
/// </summary>
public static IEnumerable<object[]> EmptyProperty
{
get
{
return new object[][] { };
}
}

/// <summary>
/// Gets the wrong test data property.
/// </summary>
public static IEnumerable<object[]> WrongDataTypeProperty
{
Expand Down Expand Up @@ -437,6 +461,15 @@ public void TestMethod4()
{
}

/// <summary>
/// The test method 5.
/// </summary>
[FrameworkV2::Microsoft.VisualStudio.TestTools.UnitTesting.TestMethodAttribute]
[DynamicData("EmptyProperty")]
public void TestMethod5()
{
}

/// <summary>
/// DataRow test method 1.
/// </summary>
Expand Down