Skip to content

Fix DisableAppDomain default value when not running in isolation under VSTest #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 23 commits into from
Nov 11, 2025
Merged

Fix DisableAppDomain default value when not running in isolation under VSTest #6900

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8325da1
Initial plan
Copilot Nov 7, 2025
02141f9
Add VSTestConsoleLocator and expand AppDomainTests with vstest.consol…
Copilot Nov 7, 2025
b78d4c9
Fix CommandLine usage in AppDomainTests
Copilot Nov 7, 2025
9d894e1
Improve error messages to include stderr in AppDomainTests
Copilot Nov 7, 2025
2f35764
Refactor AppDomainTests to reduce code duplication
Copilot Nov 7, 2025
0e82bc0
Add null check in VSTestConsoleLocator.GetTestPlatformVersion
Copilot Nov 7, 2025
327f5c9
Fix nullable reference warnings in VSTestConsoleLocator
Copilot Nov 7, 2025
19a8212
Fix formatting: remove trailing whitespace in AppDomainTests
Copilot Nov 7, 2025
c5759ab
Remove unnecessary Microsoft.TestPlatform package reference
Copilot Nov 7, 2025
ae3f00b
Fix
Youssef1313 Nov 7, 2025
9171530
Fix formatting
Youssef1313 Nov 7, 2025
80a2bfd
Fix
Youssef1313 Nov 7, 2025
604f4c1
Fix build error
Youssef1313 Nov 7, 2025
de35a2d
Remove unused method
Youssef1313 Nov 7, 2025
d99b108
Simplify
Youssef1313 Nov 7, 2025
4c3ea5f
Fir formatting
Youssef1313 Nov 7, 2025
a63b961
Fix
Youssef1313 Nov 7, 2025
0e03e8c
Apply suggestions from code review
Youssef1313 Nov 11, 2025
1e9a23a
Address review comments
Youssef1313 Nov 11, 2025
4fd8e93
Comment
Youssef1313 Nov 11, 2025
65001ad
Fix unused using
Youssef1313 Nov 11, 2025
d976cf0
Fix
Youssef1313 Nov 11, 2025
08d0abd
Fix
Youssef1313 Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CommandLine usage in AppDomainTests 
Co-authored-by: Youssef1313 <[email protected]>
  • Loading branch information
@Youssef1313
Copilot and Youssef1313 committed Nov 7, 2025
commit b78d4c95fa2f4564e191fe39950dc36c5d74329a
9 changes: 5 additions & 4 deletions test/IntegrationTests/MSTest.Acceptance.IntegrationTests/AppDomainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using Microsoft.MSTestV2.CLIAutomation;
using Microsoft.Testing.Platform.Acceptance.IntegrationTests;
using Microsoft.Testing.Platform.Acceptance.IntegrationTests.Helpers;
using Microsoft.Testing.TestInfrastructure;

namespace MSTest.Acceptance.IntegrationTests;

Expand Down Expand Up @@ -158,7 +159,7 @@ public async Task RunTests_With_VSTestConsole_Directly(bool? disableAppDomain)

// Run tests using vstest.console.exe directly
string vstestConsolePath = VSTestConsoleLocator.GetConsoleRunnerPath();
string arguments = $"\"{vstestConsolePath}\" \"{dllPath}\"";
string arguments = $"\"{dllPath}\"";
if (!string.IsNullOrEmpty(runSettings))
{
string runSettingsPath = Path.Combine(testAsset.TargetAssetPath, "test.runsettings");
Expand All @@ -168,7 +169,7 @@ public async Task RunTests_With_VSTestConsole_Directly(bool? disableAppDomain)

using var commandLine = new CommandLine();
int exitCode = await commandLine.RunAsyncAndReturnExitCodeAsync(
arguments,
$"\"{vstestConsolePath}\" {arguments}",
workingDirectory: testAsset.TargetAssetPath,
cancellationToken: TestContext.CancellationToken);

Expand Down Expand Up @@ -211,7 +212,7 @@ public async Task DiscoverTests_With_VSTestConsole_Directly(bool? disableAppDoma

// Run discovery using vstest.console.exe directly
string vstestConsolePath = VSTestConsoleLocator.GetConsoleRunnerPath();
string arguments = $"\"{vstestConsolePath}\" \"{dllPath}\" /ListTests";
string arguments = $"\"{dllPath}\" /ListTests";
if (!string.IsNullOrEmpty(runSettings))
{
string runSettingsPath = Path.Combine(testAsset.TargetAssetPath, "test.runsettings");
Expand All @@ -221,7 +222,7 @@ public async Task DiscoverTests_With_VSTestConsole_Directly(bool? disableAppDoma

using var commandLine = new CommandLine();
int exitCode = await commandLine.RunAsyncAndReturnExitCodeAsync(
arguments,
$"\"{vstestConsolePath}\" {arguments}",
workingDirectory: testAsset.TargetAssetPath,
cancellationToken: TestContext.CancellationToken);

Expand Down
Loading