Capture bind method just once #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was profiling the benchmarks from #5; one thing that stuck out to me was that the most allocations happened here:
This is weird, why would that line allocate? Then I remembered the cost of bound method wrappers... By binding
b.bind
with a receiver just once, we avoid quite literally 86% of all allocations during bind, save 14% of the memory, and save 17% of the time.This PR is in no way final (I just made the "zero value" usable, not that it is already without
bindSourceFile
), but it really shows the cost of binding methods like this.