Add update method instead of setters for CSharpType #6035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
live1206
requested review from
JoshLove-msft,
jorgerangel-msft and
m-nash
as code owners
...ages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
...ages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/TypeProvider.cs
Show resolved
Hide resolved
...ages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
...ages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/TypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Primitives/CSharpType.cs
Outdated
Show resolved
Hide resolved
…od for CSharpType
live1206
changed the title
packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Primitives/CSharpType.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Feb 21, 2025
dmnorc
pushed a commit
to dmnorc/typespec
that referenced
this pull request
Apr 9, 2025
- Remove public setter for CSharpType, add Update method instead - Remove constructor of TypeProvider for CSharpType - Update Name property of TypeProvider to return Type.Name These changes are needed for Azure/azure-sdk-for-net#48362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for Azure/azure-sdk-for-net#48362