XML Serialization Proposal #9307
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
No changes needing a change description found. |
jorgerangel-msft
force-pushed
the
xml-design
branch
from
120a7c1 to
a83aa5b
Compare
| For Azure branded libraries, models that support XML will also implement Azure Core's `IXmlSerializable` and the existing `IJsonModel<T>`: | ||
|
|
||
| ```csharp | ||
| public partial class Dog : IXmlSerializable, IJsonModel<Dog> |
There was a problem hiding this comment.
Would all XML models implement IJsonModel even if the service only supports XML?
There was a problem hiding this comment.
yeah that is the current behavior. The generator will always generate at least JSON serialization for models.
There was a problem hiding this comment.
Note this will be a change to the current behavior for libraries like Storage where they currently only have XML serialization. We may want to run this by KC.
There was a problem hiding this comment.
Why would we not implement only IPersistableModel on XML models?
There was a problem hiding this comment.
I'm fine with just supporting XML serialization if JSON is not explicitly specified, and have these models implement IPersistableModel. I was just conforming to the existing generator pattern, where we always generate JSON serialization for all models. We can always add JSON serialization support if needed in the future 👍
4 participants
contributes to #3331