Skip to content

[azure-kinect-sensor-sdk] fix imgui delete function #33231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[azure-kinect-sensor-sdk] fix imgui delete function #33231

wants to merge 2 commits into from

Conversation

@jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Aug 17, 2023 •
edited
Loading

Fixes #33137

buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4adevicedockcontrol.cpp(336): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'
buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4asourceselectiondockcontrol.cpp(37): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'

Replace the deleted function SetNextTreeNodeOpen in imgui with SetNextItemOpen.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 17, 2023
@jimwang118 jimwang118 marked this pull request as ready for review August 17, 2023 09:06
@Adela0814 Adela0814 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 17, 2023
@dan-shaw dan-shaw added the depends:upstream-changes Waiting on a change to the upstream project label Aug 17, 2023
@Adela0814 Adela0814 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 24, 2023
@jimwang118
Copy link
Contributor Author

jimwang118 commented Sep 6, 2023

Upstream PR: microsoft/Azure-Kinect-Sensor-SDK#1945

@jimwang118 jimwang118 closed this by deleting the head repository Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Adela0814 Adela0814 Adela0814 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Adela0814 Adela0814

Labels

category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[azure-kinect-sensor-sdk] Build error

3 participants

@jimwang118 @Adela0814 @dan-shaw