Fix install on Mac. #1425
Merged
Fix install on Mac. #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
requested changes
Jan 9, 2018
Extension/src/main.ts
Outdated
| if (p.binaries && p.binaries.length > 0 && | ||
| p.platforms.findIndex(plat => plat === installBlob.info.platform) !== -1 && | ||
| p.architectures.findIndex(arch => arch === installBlob.info.architecture) !== - 1) { | ||
| (p.architectures == undefined || p.architectures.findIndex(arch => arch === installBlob.info.architecture) !== - 1)) { |
Member
There was a problem hiding this comment.
always use === over ==. Is there a linting rule for this?
Contributor
Author
There was a problem hiding this comment.
So should I add triple-equal to tslint and fix all the non-triple equals (a lot)?
Contributor
Author
There was a problem hiding this comment.
I'll do that....
Member
There was a problem hiding this comment.
Talked with @sean-mcmanus, delaying the triple-equal tslint to another PR.
Contributor
Author
There was a problem hiding this comment.
I just changed this 1 instance to ===.
WardenGnaw
approved these changes
Jan 9, 2018
bobbrow
approved these changes
Jan 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix install on Mac.