-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Documenting options in launch.json #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| Visual Studio Code generates a `launch.json` with almost all of the required information. To get started | ||
| debugging you need to fill in the `program` field with the path to the executable you plan to debug. This must be specified for | ||
| both the launch and attach (if you plan to attach to a running instance at any point) configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually only true for gdb/llb in the attach case. Of course, right now, we have a bug that concord is requiring it for attach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacdavis So it sounds like we should leave it like this until we fix that?
|
Only had two comments. Rest looks good to me. |
| **dumpPath**: If you want to debug a Windows dump file, set this to the path to the dump file to start debugging in the `launch` configuration. | ||
|
|
||
| **coreDumpPath**: Full path to a core dump file to debug for the specified program. Set this to the path to the core dump file to start debugging in the `launch` configureation. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you can't debug dump files with mingw?
|
I had just a couple of minor things. Otherwise, approved. |
|
Adding documentation for launch.json |
|
|
||
| **stopAtEntry**: If set to true, the debugger should stop at the entrypoint of the target (ignored on attach). Default value is `false`. | ||
|
|
||
| **setupCommands**: JSON array of commands to execute in order to setup the GDB or LLDB. Example: `"customLaunchSetupCommands": [ { "text": "target-run", "description": "run target", "ignoreFailures": false }]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experimentation shows me that the element is NOT named "customLaunchSetupCommands", as shown here, but just "setupCommands". This example (and again down a few lines) is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abelenky Thank you. I'll get it fixed.
@pieandcakes @delmyers @jacdavis
Next attempt at documenting the launch.json. Took feedback from Pierson about trying to organize it more logically and providing some samples