Skip to content

Conversation

@Adjective-Object
Copy link
Contributor

I'm working on making this tool compatible with deno and bun for a personal project. It looks like I'm not the only one who would like to add that support (See: #1108)

Modern JS standards suggest either using a .cjs extension or a module type declaration on a package to know whether something is a commonjs module or an esm module. See: https://nodejs.org/api/packages.html#packagejson-and-file-extensions

This change adds the missing "type": "commonjs" annotation to the package.json file to allow deno to run the files correctly.

@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jul 3, 2025
@benibenj benibenj modified the milestones: June 2025, July 2025 Jul 4, 2025
@Adjective-Object
Copy link
Contributor Author

@benibenj, do you know what the stalled vsce OSS check is? Not sure if I missed a setup step before I can make contributions

@benibenj benibenj closed this Jul 7, 2025
@benibenj benibenj reopened this Jul 7, 2025
@benibenj benibenj enabled auto-merge July 7, 2025 17:56
@benibenj benibenj merged commit fafad8a into microsoft:main Jul 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants