Skip to content

reduce the settings sync debounce to 3s #239219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandy081 merged 1 commit into from
Jan 30, 2025
+4 −4
Merged

reduce the settings sync debounce to 3s #239219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/vs/platform/userDataSync/common/userDataAutoSyncService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ export class UserDataAutoSyncService extends Disposable implements IUserDataAuto
return this.syncTriggerDelayer.cancel();
}

if (options?.skipIfSyncedRecently && this.lastSyncTriggerTime && new Date().getTime() - this.lastSyncTriggerTime < 15_000) {
if (options?.skipIfSyncedRecently && this.lastSyncTriggerTime && new Date().getTime() - this.lastSyncTriggerTime < 10_000) {
this.logService.debug('[AutoSync] Skipping because sync was triggered recently.', sources);
return;
}
Expand All @@ -352,11 +352,11 @@ export class UserDataAutoSyncService extends Disposable implements IUserDataAuto
}

protected getSyncTriggerDelayTime(): number {
if (this.lastSyncTriggerTime && new Date().getTime() - this.lastSyncTriggerTime > 15_000) {
this.logService.debug('[AutoSync] Sync immediately because last sync was triggered more than 15 seconds ago.');
if (this.lastSyncTriggerTime && new Date().getTime() - this.lastSyncTriggerTime > 10_000) {
this.logService.debug('[AutoSync] Sync immediately because last sync was triggered more than 10 seconds ago.');
return 0;
}
return 10_000; /* Debounce for 10 seconds if there are no failures */
return 3_000; /* Debounce for 3 seconds if there are no failures */
}

}
Expand Down
Loading