Skip to content

Handle dotnet_root in testhost version aware way #15184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohwnd merged 9 commits into from
Jul 7, 2025
Merged

Handle dotnet_root in testhost version aware way #15184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dd3eeda
Handle dotnet_root in testhost version aware way
nohwnd Jul 3, 2025
2c64e59
Fix unit tests
nohwnd Jul 3, 2025
784ffff
Fixes
nohwnd Jul 4, 2025
2588430
Fixes
nohwnd Jul 4, 2025
97f5151
Fixes
nohwnd Jul 4, 2025
7e9eb7e
Apply suggestion from @nohwnd
nohwnd Jul 4, 2025
e8b177c
Apply suggestion from @nohwnd
nohwnd Jul 4, 2025
df7aa8c
Revert changes to playground
nohwnd Jul 4, 2025
030bc03
Merge branch 'fix-dotnet_root' of https://github.com/nohwnd/vstest in…
nohwnd Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes
  • Loading branch information
@nohwnd
nohwnd committed Jul 4, 2025
commit 2588430d943c6d8e88b169aa90a1f994e4ee9d8d
6 changes: 6 additions & 0 deletions src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,9 @@ private void SendMessageAndListenAndReportTestResults(
eventHandler.HandleLogMessage(
TestMessageLevel.Error,
TranslationLayerResources.AbortedTestsRun);
eventHandler.HandleLogMessage(
TestMessageLevel.Error,
exception.ToString());
var completeArgs = new TestRunCompleteEventArgs(
null, false, true, exception, null, null, TimeSpan.Zero);
eventHandler.HandleTestRunComplete(completeArgs, null, null, null);
Expand Down Expand Up @@ -1283,6 +1286,9 @@ private async Task SendMessageAndListenAndReportTestResultsAsync(
eventHandler.HandleLogMessage(
TestMessageLevel.Error,
TranslationLayerResources.AbortedTestsRun);
eventHandler.HandleLogMessage(
TestMessageLevel.Error,
exception.ToString());
var completeArgs = new TestRunCompleteEventArgs(
null, false, true, exception, null, null, TimeSpan.Zero);
eventHandler.HandleTestRunComplete(completeArgs, null, null, null);
Expand Down
1 change: 1 addition & 0 deletions ...oft.TestPlatform.Acceptance.IntegrationTests/TranslationLayerTests/CustomTestHostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ public void RunTestsWithCustomTestHostLauncherUsesLaunchWhenGivenAnOutdatedITest
[TestCategory("Windows-Review")]
[TestCategory("Feature")]
[RunnerCompatibilityDataSource(AfterFeature = Features.MULTI_TFM)]
// [RunnerCompatibilityDataSource("net8.0", "MostDownloaded", "net8.0")]
public void RunAllTestsWithMixedTFMsWillProvideAdditionalInformationToTheDebugger(RunnerInfo runnerInfo)
{
// Arrange
Expand Down
Loading