Skip to content

specify Win10 + maxversiontested to enable xaml APIs to be used in tests running under testhost.exe #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 26, 2024
Merged

specify Win10 + maxversiontested to enable xaml APIs to be used in tests running under testhost.exe #4888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbf0a5c
specify Win10 + maxversiontested to enable xaml APIs to be used in tests
ChrisGuzak Feb 7, 2024
e0659c6
remove redundant Win10, move maxversiontested under 10
ChrisGuzak Feb 7, 2024
448e173
go with a single maxversion tested, fixe quotes
ChrisGuzak Feb 19, 2024
e0fcc53
use 18226 per the quirk def
ChrisGuzak Feb 19, 2024
7a8e0a1
use first release OS version after the quirk test
Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/testhost.x86/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<!-- Adding same as used in TPv1 Refer: /src/vset/Agile/TestPlatform/RocksteadyCLI/app.manifest -->
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<!-- The assemblyIdentity node is needed to fix a binding problem on Win2003 (PS72518) -->
Expand All @@ -7,6 +7,8 @@
<application>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
<!-- Enables Xaml Islands -->
<maxversiontested Id="10.0.18362.0"/>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows Vista -->
Expand All @@ -24,4 +26,4 @@
</requestedPrivileges>
</security>
</trustInfo>
</assembly>
</assembly>
6 changes: 4 additions & 2 deletions src/testhost/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<!-- Adding same as used in TPv1 Refer: /src/vset/Agile/TestPlatform/RocksteadyCLI/app.manifest -->
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<!-- The assemblyIdentity node is needed to fix a binding problem on Win2003 (PS72518) -->
Expand All @@ -7,6 +7,8 @@
<application>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
<!-- Enables Xaml Islands -->
<maxversiontested Id="10.0.18362.0"/>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows Vista -->
Expand All @@ -24,4 +26,4 @@
</requestedPrivileges>
</security>
</trustInfo>
</assembly>
</assembly>
4 changes: 3 additions & 1 deletion src/vstest.console/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
<application>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
<!-- Enables Xaml Islands -->
<maxversiontested Id="10.0.18362.0"/>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows Vista -->
Expand All @@ -24,4 +26,4 @@
</requestedPrivileges>
</security>
</trustInfo>
</assembly>
</assembly>