Skip to content
This repository was archived by the owner on Aug 18, 2023. It is now read-only.

Add Simplified Chinese Localization #181

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add Simplified Chinese Localization #181

wants to merge 3 commits into from

Conversation

@le0zh0u
Copy link

@le0zh0u le0zh0u commented Jan 12, 2023

Progress / Closed on issue #
#135

What it Does

  • Add localization file for Simplified Chinese

How I Tested

N/A

Notes

  • There are some unused key in Localizable files, such as "TwitterForIphone", "UhOh", etc.
  • I couldn't create twitter API, because of Chinese phone limited. I will try and test it later.

Screenshot

N/A

@le0zh0u le0zh0u marked this pull request as ready for review January 12, 2023 18:14
@le0zh0u le0zh0u requested a review from mikaelacaron as a code owner January 12, 2023 18:14
@le0zh0u
Copy link
Author

le0zh0u commented Jan 14, 2023

After this is merged, I will translate into Traditional Chinese

@mikaelacaron
Copy link
Owner

mikaelacaron commented Jan 17, 2023

@le0zh0u Thanks so much for this! go ahead and do Traditional Chinese as well, if you would like.

I've been working on migrating data, and PR #180, which I want to complete before merging anything else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mikaelacaron mikaelacaron Awaiting requested review from mikaelacaron mikaelacaron is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@le0zh0u @mikaelacaron