Skip to content

fix: keep the backward compatibility for type hint#1052

Merged
mingrammer merged 1 commit intomasterfrom
keep-backward-compatability
Nov 7, 2024
Merged

fix: keep the backward compatibility for type hint#1052
mingrammer merged 1 commit intomasterfrom
keep-backward-compatability

Conversation

@mingrammer
Copy link
Owner

@mingrammer mingrammer commented Nov 7, 2024 •
edited
Loading

Hi @liancheng @gabriel-tessier . The | for type hint does not work for < Python 3.9. I fixed it with the Union function.

@mingrammer
Copy link
Owner Author

mingrammer commented Nov 7, 2024

This is a hotfix issue, so I should merge it immediately. Check later, please.

@mingrammer mingrammer merged commit c2c24c6 into master Nov 7, 2024
@mingrammer mingrammer deleted the keep-backward-compatability branch November 7, 2024 02:18
@mingrammer mingrammer mentioned this pull request Nov 7, 2024
Open
@mingrammer
Copy link
Owner Author

mingrammer commented Nov 7, 2024

cc @filipeaaoliveira, @tvqphuoc01

@gabriel-tessier
Copy link
Collaborator

gabriel-tessier commented Nov 14, 2024

@mingrammer
Do we need to support version < 3.9?

3.8 support end 1 month ago:
https://endoflife.date/python

The unit tests run for Python 3.9 and greater.
https://github.com/mingrammer/diagrams/actions/runs/11715386813

My opinion is to stick with the lower version of the tests 3.9.

Note for later update the Readme.
"It requires Python 3.7 or higher, check your Python version first."

@tvqphuoc01
Copy link
Collaborator

tvqphuoc01 commented Nov 18, 2024 •
edited
Loading

agree with @gabriel-tessier our pipeline is only scan code with Python version higher 3.8 so I think we don't need to support v3.8

@mingrammer
Copy link
Owner Author

mingrammer commented Nov 20, 2024 •
edited
Loading

Agree with all of you. I didn't check the EOL of 3.8.

I'll update the badge and requirements in the readme. Thank you for checking it.

@mingrammer
Copy link
Owner Author

mingrammer commented Nov 20, 2024

I made a PR: #1064

gabriel-tessier pushed a commit that referenced this pull request Nov 20, 2024
@mingrammer @gabriel-tessier
fix: keep the backward compatability for type hint (#1052)
ab50bff
gabriel-tessier added a commit that referenced this pull request Jan 13, 2025
@gabriel-tessier @mingrammer
@tvqphuoc01 @tb102122 @dependabot @nobiit @ogabriel @laiminhtrung1997 @0xAJX
Is there a node for Kubernetes itself? #979 (#1039)
31e735a 
* [979] Add icons

* fix: icons size

* bump: up to version 0.24.0

* Update version of codeql-analysis.yml (#1035)

v2 will deprecate soon so we will move to v3 🌴 
https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

* Upgrade for 3.12/3.13 (#972)

* fix tests (#1050)

* chore(deps): bump jinja2 from 3.1.2 to 3.1.4 (#1037)

* ci(test): add test trigger path

* ci(test): add test trigger path

* fix: update poetry lock

* fix: keep the backward compatability for type hint (#1052)

* Update installation command for mingrammer/round to use 'go install' with the latest version instead of 'go get'. (#1057)

* fix(node): change elixir language image to one with no background (#976)

* fix elixir image

* fix website elixir image

* Add diagrams.onprem.network.Mikrotik (#1058)

* issue-982: add azure speech to text and Azure OpenAI (#1061)

* Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. (#1038)

* issue-1056: add crowdstrike (#1062)

* fix typo for crowdstrike (#1063)

* Updated Legacy ENV Path (#1008)

* Minor Change

* fix: pin python version + fix font path

* More recent Python version

---------

Co-authored-by: tessier <tessier@luxeys.com>

* autogen.sh

* Generate node

* Revert build as node and set in _init

* Clean generated files

---------

Co-authored-by: mingrammer <mingrammer@gmail.com>
Co-authored-by: Phuoc Tran <57540319+tvqphuoc01@users.noreply.github.com>
Co-authored-by: Tobias Bruckert <62531735+tb102122@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nguyễn Đức Chiến <nobi@nobidev.com>
Co-authored-by: Gabriel Oliveira <gabrieloliver8991@gmail.com>
Co-authored-by: laiminhtrung1997 <68812829+laiminhtrung1997@users.noreply.github.com>
Co-authored-by: Abhishek Jadhav <abhishek.jadhav64@gmail.com>
gabriel-tessier pushed a commit to m1racoli/diagrams that referenced this pull request Mar 16, 2025
@mingrammer @gabriel-tessier
fix: keep the backward compatability for type hint (mingrammer#1052)
0198bc7
gabriel-tessier added a commit to m1racoli/diagrams that referenced this pull request Mar 16, 2025
@gabriel-tessier @mingrammer
@tvqphuoc01 @tb102122 @dependabot @nobiit @ogabriel @laiminhtrung1997 @0xAJX
Is there a node for Kubernetes itself? mingrammer#979 (mingrammer#1039)
7ed963e 
* [979] Add icons

* fix: icons size

* bump: up to version 0.24.0

* Update version of codeql-analysis.yml (mingrammer#1035)

v2 will deprecate soon so we will move to v3 🌴 
https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

* Upgrade for 3.12/3.13 (mingrammer#972)

* fix tests (mingrammer#1050)

* chore(deps): bump jinja2 from 3.1.2 to 3.1.4 (mingrammer#1037)

* ci(test): add test trigger path

* ci(test): add test trigger path

* fix: update poetry lock

* fix: keep the backward compatability for type hint (mingrammer#1052)

* Update installation command for mingrammer/round to use 'go install' with the latest version instead of 'go get'. (mingrammer#1057)

* fix(node): change elixir language image to one with no background (mingrammer#976)

* fix elixir image

* fix website elixir image

* Add diagrams.onprem.network.Mikrotik (mingrammer#1058)

* issue-982: add azure speech to text and Azure OpenAI (mingrammer#1061)

* Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. (mingrammer#1038)

* issue-1056: add crowdstrike (mingrammer#1062)

* fix typo for crowdstrike (mingrammer#1063)

* Updated Legacy ENV Path (mingrammer#1008)

* Minor Change

* fix: pin python version + fix font path

* More recent Python version

---------

Co-authored-by: tessier <tessier@luxeys.com>

* autogen.sh

* Generate node

* Revert build as node and set in _init

* Clean generated files

---------

Co-authored-by: mingrammer <mingrammer@gmail.com>
Co-authored-by: Phuoc Tran <57540319+tvqphuoc01@users.noreply.github.com>
Co-authored-by: Tobias Bruckert <62531735+tb102122@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nguyễn Đức Chiến <nobi@nobidev.com>
Co-authored-by: Gabriel Oliveira <gabrieloliver8991@gmail.com>
Co-authored-by: laiminhtrung1997 <68812829+laiminhtrung1997@users.noreply.github.com>
Co-authored-by: Abhishek Jadhav <abhishek.jadhav64@gmail.com>
kakakakakku pushed a commit to kakakakakku/diagrams that referenced this pull request Apr 12, 2025
@gabriel-tessier @mingrammer
@tvqphuoc01 @tb102122 @dependabot @nobiit @ogabriel @laiminhtrung1997 @0xAJX @kakakakakku
Is there a node for Kubernetes itself? mingrammer#979 (mingrammer#1039)
16fc697 
* [979] Add icons

* fix: icons size

* bump: up to version 0.24.0

* Update version of codeql-analysis.yml (mingrammer#1035)

v2 will deprecate soon so we will move to v3 🌴 
https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

* Upgrade for 3.12/3.13 (mingrammer#972)

* fix tests (mingrammer#1050)

* chore(deps): bump jinja2 from 3.1.2 to 3.1.4 (mingrammer#1037)

* ci(test): add test trigger path

* ci(test): add test trigger path

* fix: update poetry lock

* fix: keep the backward compatability for type hint (mingrammer#1052)

* Update installation command for mingrammer/round to use 'go install' with the latest version instead of 'go get'. (mingrammer#1057)

* fix(node): change elixir language image to one with no background (mingrammer#976)

* fix elixir image

* fix website elixir image

* Add diagrams.onprem.network.Mikrotik (mingrammer#1058)

* issue-982: add azure speech to text and Azure OpenAI (mingrammer#1061)

* Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. (mingrammer#1038)

* issue-1056: add crowdstrike (mingrammer#1062)

* fix typo for crowdstrike (mingrammer#1063)

* Updated Legacy ENV Path (mingrammer#1008)

* Minor Change

* fix: pin python version + fix font path

* More recent Python version

---------

Co-authored-by: tessier <tessier@luxeys.com>

* autogen.sh

* Generate node

* Revert build as node and set in _init

* Clean generated files

---------

Co-authored-by: mingrammer <mingrammer@gmail.com>
Co-authored-by: Phuoc Tran <57540319+tvqphuoc01@users.noreply.github.com>
Co-authored-by: Tobias Bruckert <62531735+tb102122@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nguyễn Đức Chiến <nobi@nobidev.com>
Co-authored-by: Gabriel Oliveira <gabrieloliver8991@gmail.com>
Co-authored-by: laiminhtrung1997 <68812829+laiminhtrung1997@users.noreply.github.com>
Co-authored-by: Abhishek Jadhav <abhishek.jadhav64@gmail.com>
fabianorosa1 pushed a commit to fabianorosa1/diagrams-with-sap that referenced this pull request Oct 29, 2025
@mingrammer
fix: keep the backward compatability for type hint (mingrammer#1052)
45c0cce
fabianorosa1 pushed a commit to fabianorosa1/diagrams-with-sap that referenced this pull request Oct 29, 2025
@gabriel-tessier @mingrammer
@tvqphuoc01 @tb102122 @dependabot @nobiit @ogabriel @laiminhtrung1997 @0xAJX
Is there a node for Kubernetes itself? mingrammer#979 (mingrammer#1039)
472d950 
* [979] Add icons

* fix: icons size

* bump: up to version 0.24.0

* Update version of codeql-analysis.yml (mingrammer#1035)

v2 will deprecate soon so we will move to v3 🌴 
https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

* Upgrade for 3.12/3.13 (mingrammer#972)

* fix tests (mingrammer#1050)

* chore(deps): bump jinja2 from 3.1.2 to 3.1.4 (mingrammer#1037)

* ci(test): add test trigger path

* ci(test): add test trigger path

* fix: update poetry lock

* fix: keep the backward compatability for type hint (mingrammer#1052)

* Update installation command for mingrammer/round to use 'go install' with the latest version instead of 'go get'. (mingrammer#1057)

* fix(node): change elixir language image to one with no background (mingrammer#976)

* fix elixir image

* fix website elixir image

* Add diagrams.onprem.network.Mikrotik (mingrammer#1058)

* issue-982: add azure speech to text and Azure OpenAI (mingrammer#1061)

* Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. (mingrammer#1038)

* issue-1056: add crowdstrike (mingrammer#1062)

* fix typo for crowdstrike (mingrammer#1063)

* Updated Legacy ENV Path (mingrammer#1008)

* Minor Change

* fix: pin python version + fix font path

* More recent Python version

---------

Co-authored-by: tessier <tessier@luxeys.com>

* autogen.sh

* Generate node

* Revert build as node and set in _init

* Clean generated files

---------

Co-authored-by: mingrammer <mingrammer@gmail.com>
Co-authored-by: Phuoc Tran <57540319+tvqphuoc01@users.noreply.github.com>
Co-authored-by: Tobias Bruckert <62531735+tb102122@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nguyễn Đức Chiến <nobi@nobidev.com>
Co-authored-by: Gabriel Oliveira <gabrieloliver8991@gmail.com>
Co-authored-by: laiminhtrung1997 <68812829+laiminhtrung1997@users.noreply.github.com>
Co-authored-by: Abhishek Jadhav <abhishek.jadhav64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingrammer @gabriel-tessier @tvqphuoc01