This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Add updates through go1.18 #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2022 10:37
Also drop Gopkg files
swenson
commented
Jun 30, 2022
| }, nil) | ||
|
|
||
| Platforms_1_5 = append(Platforms_1_4, []Platform{ | ||
| Platforms_1_5 = addDrop(Platforms_1_4, []Platform{ |
There was a problem hiding this comment.
I noticed some very strange things happening if multiple appends were done around here, with the 1.6 and 1.7 slices being all messed up, so I changed everything to use addDrop, which makes full copies.
swenson
commented
Jun 30, 2022
| "go1.15", | ||
| "go1.16", | ||
| "go1.17", | ||
| "go1.18", |
There was a problem hiding this comment.
This would be very tedious to maintain if we kept track of 10+ patch versions per minor version
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop Gopkg files.
Tests pass locally.
I checked compatibility using https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63