Skip to content

Conversation

@heew
Copy link
Contributor

@heew heew commented Mar 15, 2018

Fixes issue #190

Copy link

@lion2486 lion2486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks at first sign to be a reasonable one. Maybe the count($this->sheets) will get the same number but it's a quick fix.
Tested on my own and it works.

@hnx8 hnx8 mentioned this pull request Jul 6, 2018
@hnx8
Copy link

hnx8 commented Jul 6, 2018

I noticed when I was doing enhancement, as far as seeing the contents of the actual Xlsx file,
it seems more appropriate that the "localSheetId" are numbered in order from the first sheet, regardless of whether AutoFilter is specified or not.
(so, in # 207 I fixed it in a form that seemed better)

@mk-j mk-j merged commit 5b77d3d into mk-j:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants