Skip to content

Conversation

@ttpho
Copy link
Contributor

@ttpho ttpho commented Oct 4, 2022

Proposed Changes

added command input random:

  • inputRandomText
  • inputRandomNumber
  • inputRandomEmail
  • inputRandomPersonName
- inputRandomNumber: # This command will add text as number with length is 2, 10 <= number <= 99
      length: 2
- inputRandomText: # This command will add random text with a length is 3, as Abc, ads, asd, .... 
      inputType: "text"
      length: 3
- inputRandomEmail # This command will add a random email address as [email protected]
- inputRandomPersonName  # This command will add a random person's name as Liam Smith

Testing

MaestroCommandSerializationTest.kt

IntegrationTest.kt

Issues Fixed

Copy link
Collaborator

@dmitry-zaitsev dmitry-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It mostly looks good with few minor comments on the API

@ttpho
Copy link
Contributor Author

ttpho commented Oct 4, 2022

@dmitry-zaitsev Thank you for your review. I will refactore my source code.

@ttpho
Copy link
Contributor Author

ttpho commented Oct 5, 2022

@dmitry-zaitsev Please help me review this PR again when you are free. Sorry for any mistakes. English is not my native language.

Copy link
Collaborator

@dmitry-zaitsev dmitry-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@dmitry-zaitsev
Copy link
Collaborator

@ttpho could you please share your Twitter and/or LinkedIn profile so that we can give you a proper shout out?

@dmitry-zaitsev dmitry-zaitsev merged commit 559db50 into mobile-dev-inc:main Oct 5, 2022
@ttpho
Copy link
Contributor Author

ttpho commented Oct 5, 2022

@dmitry-zaitsev Thank you for your review and approval 🙇
My LinkedIn profile is tpho

I wrote an article about Maestro. I hope more people use maestro

https://ttpho.github.io/2022-09-25-maestro/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants